Merge pull request #896 from scidsg/bug-fix

Fix Unique Constraint Violation in Field Creation

hushline/settings/common.py

@@ -348,6 +348,16 @@ def handle_field_post(username: Username) -> Response | None:
     if field_form.validate():
         # Create a new field
         if field_form.submit.name in request.form:
+            # Get the highest existing sort_order for this username
+            max_sort_order = (
+                db.session.scalar(
+                    db.select(db.func.coalesce(db.func.max(FieldDefinition.sort_order), 0)).filter(
+                        FieldDefinition.username_id == username.id
+                    )
+                )
+                or 0
+            )
+
             field_definition = FieldDefinition(
                 username,
                 field_form.label.data,
@@ -357,6 +367,9 @@ def handle_field_post(username: Username) -> Response | None:
                 field_form.encrypted.data,
                 [c["choice"] for c in field_form.choices.data],
             )
+
+            field_definition.sort_order = max_sort_order + 1  # Ensure unique ordering
+
             db.session.add(field_definition)
             db.session.commit()
             flash("New field added.")

hushline/version.py

@@ -1 +1 @@
-__version__ = "0.3.83"
+__version__ = "0.3.84"