Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: article contribs validation tests #803

Merged
merged 1 commit into from
Jan 14, 2025
Merged

Fix: article contribs validation tests #803

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
102 changes: 49 additions & 53 deletions tests/sps/validation/test_article_contribs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,12 +103,13 @@ def test_without_role(self):
"sub_item": '@content-type="https://credit.niso.org/contributor-roles/*',
"validation_type": "value in list",
"response": "ERROR",
"expected_value": [
'<role content-type="https://credit.niso.org/contributor-roles/conceptualization/">Conceptualization</role>',
'<role content-type="https://credit.niso.org/contributor-roles/data-curation/">Data curation</role>',
],
"expected_value": "one of ['<role "
'content-type="https://credit.niso.org/contributor-roles/conceptualization/">Conceptualization</role>\', '
"'<role "
'content-type="https://credit.niso.org/contributor-roles/data-curation/">Data '
"curation</role>']",
"got_value": None,
"message": """Got None, expected ['<role content-type="https://credit.niso.org/contributor-roles/conceptualization/">Conceptualization</role>', '<role content-type="https://credit.niso.org/contributor-roles/data-curation/">Data curation</role>']""",
"message": """Got None, expected one of ['<role content-type="https://credit.niso.org/contributor-roles/conceptualization/">Conceptualization</role>', '<role content-type="https://credit.niso.org/contributor-roles/data-curation/">Data curation</role>']""",
"advice": """Provide the correct CRediT taxonomy: ['<role content-type="https://credit.niso.org/contributor-roles/conceptualization/">Conceptualization</role>', '<role content-type="https://credit.niso.org/contributor-roles/data-curation/">Data curation</role>']""",
"data": {
'contrib_full_name': 'Prof FRANCISCO VENEGAS-MARTÍNEZ Nieto',
Expand Down Expand Up @@ -185,15 +186,13 @@ def test_role_and_collab_list_empty(self):
"sub_item": '@content-type="https://credit.niso.org/contributor-roles/*',
"validation_type": "value in list",
"response": "ERROR",
"expected_value": [
"<role "
'content-type="https://credit.niso.org/contributor-roles/conceptualization/">Conceptualization</role>',
"<role "
"expected_value": "one of ['<role "
'content-type="https://credit.niso.org/contributor-roles/conceptualization/">Conceptualization</role>\', '
"'<role "
'content-type="https://credit.niso.org/contributor-roles/data-curation/">Data '
"curation</role>",
],
"curation</role>']",
"got_value": '<role content-type="None">None</role>',
"message": """Got <role content-type="None">None</role>, expected ['<role content-type="https://credit.niso.org/contributor-roles/conceptualization/">Conceptualization</role>', '<role content-type="https://credit.niso.org/contributor-roles/data-curation/">Data curation</role>']""",
"message": """Got <role content-type="None">None</role>, expected one of ['<role content-type="https://credit.niso.org/contributor-roles/conceptualization/">Conceptualization</role>', '<role content-type="https://credit.niso.org/contributor-roles/data-curation/">Data curation</role>']""",
"advice": """Provide the correct CRediT taxonomy: ['<role content-type="https://credit.niso.org/contributor-roles/conceptualization/">Conceptualization</role>', '<role content-type="https://credit.niso.org/contributor-roles/data-curation/">Data curation</role>']""",
"data": {
'contrib_full_name': 'Prof FRANCISCO VENEGAS-MARTÍNEZ Nieto',
Expand Down Expand Up @@ -265,14 +264,12 @@ def test_role_without_collab_list(self):
"validation_type": "value in list",
"response": "ERROR",
"got_value": '<role content-type="None">Data curation</role>',
"expected_value": [
"<role "
'content-type="https://credit.niso.org/contributor-roles/conceptualization/">Conceptualization</role>',
"<role "
'content-type="https://credit.niso.org/contributor-roles/data-curation/">Data '
"curation</role>",
],
"message": """Got <role content-type="None">Data curation</role>, expected ['<role content-type="https://credit.niso.org/contributor-roles/conceptualization/">Conceptualization</role>', '<role content-type="https://credit.niso.org/contributor-roles/data-curation/">Data curation</role>']""",
"expected_value": "one of ['<role "
'content-type="https://credit.niso.org/contributor-roles/conceptualization/">Conceptualization</role>\', '
"'<role "
'content-type="https://credit.niso.org/contributor-roles/data-curation/">Data '
"curation</role>']",
"message": """Got <role content-type="None">Data curation</role>, expected one of ['<role content-type="https://credit.niso.org/contributor-roles/conceptualization/">Conceptualization</role>', '<role content-type="https://credit.niso.org/contributor-roles/data-curation/">Data curation</role>']""",
"advice": """Provide the correct CRediT taxonomy: ['<role content-type="https://credit.niso.org/contributor-roles/conceptualization/">Conceptualization</role>', '<role content-type="https://credit.niso.org/contributor-roles/data-curation/">Data curation</role>']""",
"data": {
'contrib_full_name': 'Prof FRANCISCO VENEGAS-MARTÍNEZ Nieto',
Expand Down Expand Up @@ -357,14 +354,12 @@ def test_role_no_text_with_collab_list(self):
"validation_type": "value in list",
"response": "ERROR",
"got_value": '<role content-type="https://credit.niso.org/contributor-roles/data-curation/">None</role>',
"expected_value": [
"<role "
'content-type="https://credit.niso.org/contributor-roles/conceptualization/">Conceptualization</role>',
"<role "
"expected_value": "one of ['<role "
'content-type="https://credit.niso.org/contributor-roles/conceptualization/">Conceptualization</role>\', '
"'<role "
'content-type="https://credit.niso.org/contributor-roles/data-curation/">Data '
"curation</role>",
],
"message": """Got <role content-type="https://credit.niso.org/contributor-roles/data-curation/">None</role>, expected ['<role content-type="https://credit.niso.org/contributor-roles/conceptualization/">Conceptualization</role>', '<role content-type="https://credit.niso.org/contributor-roles/data-curation/">Data curation</role>']""",
"curation</role>']",
"message": """Got <role content-type="https://credit.niso.org/contributor-roles/data-curation/">None</role>, expected one of ['<role content-type="https://credit.niso.org/contributor-roles/conceptualization/">Conceptualization</role>', '<role content-type="https://credit.niso.org/contributor-roles/data-curation/">Data curation</role>']""",
"advice": """Provide the correct CRediT taxonomy: ['<role content-type="https://credit.niso.org/contributor-roles/conceptualization/">Conceptualization</role>', '<role content-type="https://credit.niso.org/contributor-roles/data-curation/">Data curation</role>']""",
"data": {
'contrib_full_name': 'Prof FRANCISCO VENEGAS-MARTÍNEZ Nieto',
Expand Down Expand Up @@ -455,14 +450,12 @@ def test_wrong_role_and_collab_list(self):
"validation_type": "value in list",
"response": "ERROR",
"got_value": '<role content-type="https://credit.niso.org/contributor-roles/data-curan/">Data curation</role>',
"expected_value": [
"<role "
'content-type="https://credit.niso.org/contributor-roles/conceptualization/">Conceptualization</role>',
"<role "
"expected_value": "one of ['<role "
'content-type="https://credit.niso.org/contributor-roles/conceptualization/">Conceptualization</role>\', '
"'<role "
'content-type="https://credit.niso.org/contributor-roles/data-curation/">Data '
"curation</role>",
],
"message": """Got <role content-type="https://credit.niso.org/contributor-roles/data-curan/">Data curation</role>, expected ['<role content-type="https://credit.niso.org/contributor-roles/conceptualization/">Conceptualization</role>', '<role content-type="https://credit.niso.org/contributor-roles/data-curation/">Data curation</role>']""",
"curation</role>']",
"message": """Got <role content-type="https://credit.niso.org/contributor-roles/data-curan/">Data curation</role>, expected one of ['<role content-type="https://credit.niso.org/contributor-roles/conceptualization/">Conceptualization</role>', '<role content-type="https://credit.niso.org/contributor-roles/data-curation/">Data curation</role>']""",
"advice": """Provide the correct CRediT taxonomy: ['<role content-type="https://credit.niso.org/contributor-roles/conceptualization/">Conceptualization</role>', '<role content-type="https://credit.niso.org/contributor-roles/data-curation/">Data curation</role>']""",
"data": {
'contrib_full_name': 'Prof FRANCISCO VENEGAS-MARTÍNEZ Nieto',
Expand Down Expand Up @@ -552,12 +545,11 @@ def test_success_role(self):
"sub_item": '@content-type="https://credit.niso.org/contributor-roles/*',
"validation_type": "value in list",
"response": "OK",
"expected_value": [
'<role content-type="https://credit.niso.org/contributor-roles/conceptualization/">Conceptualization</role>',
'<role content-type="https://credit.niso.org/contributor-roles/data-curation/">Data curation</role>',
],
"expected_value": '<role '
'content-type="https://credit.niso.org/contributor-roles/data-curation/">Data '
'curation</role>',
"got_value": '<role content-type="https://credit.niso.org/contributor-roles/data-curation/">Data curation</role>',
"message": """Got <role content-type="https://credit.niso.org/contributor-roles/data-curation/">Data curation</role>, expected ['<role content-type="https://credit.niso.org/contributor-roles/conceptualization/">Conceptualization</role>', '<role content-type="https://credit.niso.org/contributor-roles/data-curation/">Data curation</role>']""",
"message": """Got <role content-type="https://credit.niso.org/contributor-roles/data-curation/">Data curation</role>, expected one of ['<role content-type="https://credit.niso.org/contributor-roles/conceptualization/">Conceptualization</role>', '<role content-type="https://credit.niso.org/contributor-roles/data-curation/">Data curation</role>']""",
"advice": None,
"data": {
'contrib_full_name': 'Prof FRANCISCO VENEGAS-MARTÍNEZ Nieto',
Expand Down Expand Up @@ -880,7 +872,7 @@ def test_validate_authors_orcid_is_unique_ok(self):
"sub_item": '@contrib-id-type="orcid"',
"validation_type": "uniqueness",
"response": "OK",
"expected_value": "Unique ORCID values",
"expected_value": {'0000-3333-1238-6873': ['Vanessa M. Higa'], '0990-0001-0058-4853': ['Prof FRANCISCO VENEGAS-MARTÍNEZ Nieto']},
"got_value": {
'0000-3333-1238-6873': ['Vanessa M. Higa'],
'0990-0001-0058-4853': ['Prof FRANCISCO VENEGAS-MARTÍNEZ Nieto']
Expand Down Expand Up @@ -1015,7 +1007,7 @@ def test_validate_authors_orcid_is_registered_success(self):
"sub_item": '@contrib-id-type="orcid"',
"validation_type": "registered",
"response": "OK",
"expected_value": 'Prof FRANCISCO VENEGAS MARTÍNEZ Nieto',
"expected_value": 'FRANCISCO VENEGAS MARTÍNEZ Nieto',
"got_value": 'FRANCISCO VENEGAS MARTÍNEZ Nieto',
"message": "Got FRANCISCO VENEGAS MARTÍNEZ Nieto, expected Prof FRANCISCO VENEGAS MARTÍNEZ Nieto",
"advice": None,
Expand Down Expand Up @@ -1346,7 +1338,9 @@ def test_validate(self):
"sub_item": '@contrib-id-type="orcid"',
"validation_type": "uniqueness",
"response": "OK",
"expected_value": "Unique ORCID values",
"expected_value": {
'0000-3333-1238-6873': ['Vanessa M. Higa'],
'0990-0001-0058-4853': ['Prof FRANCISCO VENEGAS-MARTÍNEZ Nieto']},
"got_value": {
'0000-3333-1238-6873': ['Vanessa M. Higa'],
'0990-0001-0058-4853': ['Prof FRANCISCO VENEGAS-MARTÍNEZ Nieto']
Expand All @@ -1368,12 +1362,13 @@ def test_validate(self):
"sub_item": '@content-type="https://credit.niso.org/contributor-roles/*',
"validation_type": "value in list",
"response": "ERROR",
"expected_value": [
'<role content-type="https://credit.niso.org/contributor-roles/conceptualization/">Conceptualization</role>',
'<role content-type="https://credit.niso.org/contributor-roles/data-curation/">Data curation</role>',
],
"expected_value": "one of ['<role "
'content-type="https://credit.niso.org/contributor-roles/conceptualization/">Conceptualization</role>\', '
"'<role "
'content-type="https://credit.niso.org/contributor-roles/data-curation/">Data '
"curation</role>']",
"got_value": None,
"message": """Got None, expected ['<role content-type="https://credit.niso.org/contributor-roles/conceptualization/">Conceptualization</role>', '<role content-type="https://credit.niso.org/contributor-roles/data-curation/">Data curation</role>']""",
"message": """Got None, expected one of ['<role content-type="https://credit.niso.org/contributor-roles/conceptualization/">Conceptualization</role>', '<role content-type="https://credit.niso.org/contributor-roles/data-curation/">Data curation</role>']""",
"advice": """Provide the correct CRediT taxonomy: ['<role content-type="https://credit.niso.org/contributor-roles/conceptualization/">Conceptualization</role>', '<role content-type="https://credit.niso.org/contributor-roles/data-curation/">Data curation</role>']""",
"data": {
'contrib_full_name': 'Prof FRANCISCO VENEGAS-MARTÍNEZ Nieto',
Expand Down Expand Up @@ -1495,12 +1490,13 @@ def test_validate(self):
"sub_item": '@content-type="https://credit.niso.org/contributor-roles/*',
"validation_type": "value in list",
"response": "ERROR",
"expected_value": [
'<role content-type="https://credit.niso.org/contributor-roles/conceptualization/">Conceptualization</role>',
'<role content-type="https://credit.niso.org/contributor-roles/data-curation/">Data curation</role>',
],
"expected_value": "one of ['<role "
'content-type="https://credit.niso.org/contributor-roles/conceptualization/">Conceptualization</role>\', '
"'<role "
'content-type="https://credit.niso.org/contributor-roles/data-curation/">Data '
"curation</role>']",
"got_value": None,
"message": """Got None, expected ['<role content-type="https://credit.niso.org/contributor-roles/conceptualization/">Conceptualization</role>', '<role content-type="https://credit.niso.org/contributor-roles/data-curation/">Data curation</role>']""",
"message": """Got None, expected one of ['<role content-type="https://credit.niso.org/contributor-roles/conceptualization/">Conceptualization</role>', '<role content-type="https://credit.niso.org/contributor-roles/data-curation/">Data curation</role>']""",
"advice": """Provide the correct CRediT taxonomy: ['<role content-type="https://credit.niso.org/contributor-roles/conceptualization/">Conceptualization</role>', '<role content-type="https://credit.niso.org/contributor-roles/data-curation/">Data curation</role>']""",
"data": {
'contrib_full_name': 'Vanessa M. Higa',
Expand Down Expand Up @@ -1604,7 +1600,7 @@ def test_validate_unique_orcid_for_authors_with_same_name(self):
"sub_item": '@contrib-id-type="orcid"',
"validation_type": "uniqueness",
"response": "OK",
"expected_value": "Unique ORCID values",
"expected_value": {'0990-0001-0058-4853': ['Prof FRANCISCO VENEGAS-MARTÍNEZ Nieto']},
"got_value": {
'0990-0001-0058-4853': [
'Prof FRANCISCO VENEGAS-MARTÍNEZ Nieto'
Expand Down