Fix: journal-meta advice #890
Conversation
| is_valid=is_valid, | ||
| expected=expected_value, | ||
| obtained=self.journal_acronym.text, | ||
| advice='Mark journal acronym value with <journal-meta><journal-id journal-id-type="publisher-id">{}</journal-id>'.format(expected_value), |
There was a problem hiding this comment.
@Rossi-Luciano
Mark journal acronym value with <journal-meta><journal-id journal-id-type="publisher-id">{}</journal-id>
troque por
Mark journal acronym value with <journal-id journal-id-type="publisher-id">{}</journal-id> in <journal-meta>
There was a problem hiding this comment.
OK, @robertatakenaka
| is_valid=is_valid, | ||
| expected=expected_value, | ||
| obtained=self.journal_titles.journal_title, | ||
| advice='Mark journal title value with <journal-meta><journal-title-group><journal-title>', |
There was a problem hiding this comment.
@Rossi-Luciano remover <journal-meta>e adicionar ao final da mensagem in <journal-meta>
There was a problem hiding this comment.
OK, @robertatakenaka
| @@ -226,7 +240,7 @@ def validate_publisher_names(self, publisher_name_list, error_level="CRITICAL"): | |||
| is_valid=is_valid, | |||
| expected=expected, | |||
| obtained=obtained, | |||
| advice=f'Provide the expected publisher name: {expected}', | |||
| advice=f'Mark publisher name values with <journal-meta><publisher><publisher-name>{expected}</publisher-name></publisher></journal-meta>', | |||
There was a problem hiding this comment.
@Rossi-Luciano corrigir
There was a problem hiding this comment.
OK, @robertatakenaka
| @@ -326,7 +340,7 @@ def nlm_ta_id_validation(self, expected_value, error_level="CRITICAL"): | |||
| is_valid=is_valid, | |||
| expected=expected_value, | |||
| obtained=self.nlm_ta, | |||
| advice='Provide an nlm-ta value as expected: {}'.format(expected_value), | |||
| advice=f'Mark an nlm-ta value with <journal-meta><journal-id journal-id-type="nlm-ta">{expected_value}</journal-id></journal-meta>', | |||
There was a problem hiding this comment.
@Rossi-Luciano corrigir
There was a problem hiding this comment.
OK, @robertatakenaka
| is_valid=is_valid, | ||
| expected='<issn pub-type="{}">{}</issn>'.format(tp, issn_expected), | ||
| obtained='<issn pub-type="{}">{}</issn>'.format(tp, issn_obtained), | ||
| advice='Mark ISSN value with <journal-meta><issn pub-type="{}">{}</issn>'.format(tp, issn_expected), |
There was a problem hiding this comment.
@Rossi-Luciano Trocar 'Mark ISSN value with <journal-meta><issn pub-type="{}">{}</issn>'.format(tp, issn_expected) por
'Mark {} ISSN with <journal-meta><issn pub-type="{}">{}</issn>'.format(name, tp, issn_expected)
Sendo name, deve ser electronic ou print
There was a problem hiding this comment.
OK, @robertatakenaka
| is_valid=is_valid, | ||
| expected=expected_value, | ||
| obtained=self.journal_acronym.text, | ||
| advice='Mark journal acronym value with <journal-id journal-id-type="publisher-id">{}</journal-id> in <journal-meta>'.format(expected_value), |
There was a problem hiding this comment.
@Rossi-Luciano remover a palavra value (Mark journal acronym with)
There was a problem hiding this comment.
OK, @robertatakenaka
| is_valid=is_valid, | ||
| expected=expected_value, | ||
| obtained=self.journal_titles.journal_title, | ||
| advice='Mark journal title value with <journal-title-group><journal-title> in <journal-meta>', |
There was a problem hiding this comment.
@Rossi-Luciano remover 'value' e use
Troque:
'Mark journal title value with <journal-title-group><journal-title> in <journal-meta>' por
Mark journal title with <journal-title> inside <journal-title-group>' (pode omitir journal-meta porque só existe journal-title-group dentro de journal-meta)
There was a problem hiding this comment.
OK, @robertatakenaka
| @@ -145,7 +159,7 @@ def abbreviated_journal_title_validation(self, expected_value, error_level="CRIT | |||
| is_valid=is_valid, | |||
| expected=expected_value, | |||
| obtained=self.journal_titles.abbreviated_journal_title, | |||
| advice='Provide a journal title value as expected: {}'.format(expected_value), | |||
| advice='Mark abbreviated journal title value with <journal-title-group><abbrev-journal-title> in <journal-meta>', | |||
There was a problem hiding this comment.
@Rossi-Luciano ajuste a mensagem de acordo com os comentários anteriores
There was a problem hiding this comment.
OK, @robertatakenaka
| @@ -81,7 +82,7 @@ def validate_issn(self, issns_dict, error_level="CRITICAL"): | |||
| is_valid=is_valid, | |||
| expected='<issn pub-type="{}">{}</issn>'.format(tp, issn_expected), | |||
| obtained='<issn pub-type="{}">{}</issn>'.format(tp, issn_obtained), | |||
| advice='Mark ISSN value with <journal-meta><issn pub-type="{}">{}</issn>'.format(tp, issn_expected), | |||
| advice='Mark {} ISSN with <journal-meta><issn pub-type="{}">{}</issn>'.format(name, tp, issn_expected), | |||
There was a problem hiding this comment.
@Rossi-Luciano troque <journal-meta><issn pub-type="{}">{}</issn>' por <issn pub-type="{}">{}</issn>' inside <journal-meta>
There was a problem hiding this comment.
OK, @robertatakenaka
O que esse PR faz?
Ajusta o conteúdo de
advicenas funções de validação dejournal-meta.Onde a revisão poderia começar?
Por commit.
Como este poderia ser testado manualmente?
NA.
Algum cenário de contexto que queira dar?
NA.
Screenshots
NA.
Quais são tickets relevantes?
TK #878
Referências
NA.