Use Kithe::Model in access policy instead of Collection / Work / Asset. #1987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrochkind
reviewed
Dec 8, 2022
|
|
||
| role :admin, proc { |user| user&.admin_user? } do | ||
| can [:destroy, :publish], Kithe::Model |
There was a problem hiding this comment.
I didn't realize you could do two at once in an array like this, but confirmed with access_granted docs, ok!
|
I thought you might through the spec in with this one too! But no matter! |
|
Thanks. The spec is coming soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #1948
This will greatly simplify our access policy.
We can change the two calls to authorize! that mention
CollectionandWorkback to the way they are now once chaps-io/access-granted#56 is merged -- if we want.