Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't assume config exists. #271

Merged
merged 1 commit into from
Nov 21, 2024
Merged

Don't assume config exists. #271

merged 1 commit into from
Nov 21, 2024

Conversation

Carreau
Copy link
Contributor

@Carreau Carreau commented Nov 21, 2024

Closes #270

@bsipocz bsipocz added the bug label Nov 21, 2024
@bsipocz bsipocz added this to the 1.3.0 milestone Nov 21, 2024
bsipocz
bsipocz approved these changes Nov 21, 2024
View reviewed changes
Copy link
Member

@bsipocz bsipocz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Carreau! I don't suppose we can test this without a lot of of hackery, so I would say we go ahead and merge this.

@bsipocz bsipocz merged commit a0ec9b6 into scientific-python:main Nov 21, 2024
22 checks passed
@bsipocz
Copy link
Member

bsipocz commented Nov 21, 2024

I'll have a look around to see any imminent maintenance is necessary, and if it's all good shape will try to do a release this week.

@Carreau
Copy link
Contributor Author

Carreau commented Nov 21, 2024

Thanks.

I've opened a issue to track this new release: #272

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bsipocz bsipocz bsipocz approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
1.3.0
Development

Successfully merging this pull request may close these issues.

Don't assume doctestmodules exists on Namespace
2 participants
@Carreau @bsipocz