Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Add tabs shortcode example #403

Merged

Conversation

alphapapa
Copy link
Contributor

See #397.

This also adds a shortcode-example shortcode, only used in our documentation, which distinguishes the rendered shortcode examples from the content in the page describing them.

It also fixes a small bug (encountered when adding the tabs shortcode example) regarding nested Markdown code blocks in the generated documentation.

Copy link

netlify bot commented Nov 9, 2023

Deploy Preview for scientific-python-hugo-theme ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit d484c29
🔍 Latest deploy log https://app.netlify.com/sites/scientific-python-hugo-theme/deploys/655268ae961acb000806a53a
😎 Deploy Preview https://deploy-preview-403--scientific-python-hugo-theme.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 82
Accessibility: 100
Best Practices: 100
SEO: 92
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@alphapapa alphapapa mentioned this pull request Nov 9, 2023
18 tasks
@alphapapa alphapapa self-assigned this Nov 9, 2023
@alphapapa alphapapa added type: Bug fix Something isn't working type: Enhancement New feature or request labels Nov 9, 2023
@alphapapa alphapapa added this to the 0.5 milestone Nov 9, 2023
@jarrodmillman
Copy link
Member

Would put the style change stuff in a separate PR? Let's keep this one focused on just adding the tabs shortcode example.

This section should remain at the bottom of the file.
The triple-backtick in shortdoc examples with embedded code blocks was
breaking out of this generated code block early.
@jarrodmillman jarrodmillman merged commit 7e6d8ae into scientific-python:main Nov 13, 2023
6 checks passed
@alphapapa alphapapa deleted the wip/docs-tabs-shortcode branch November 13, 2023 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: Bug fix Something isn't working type: Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants