Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: fixed showOnTop #541

Merged
merged 2 commits into from
Mar 12, 2024
Merged

BUG: fixed showOnTop #541

merged 2 commits into from
Mar 12, 2024

Conversation

Schefflera-Arboricola
Copy link
Contributor

@Schefflera-Arboricola Schefflera-Arboricola commented Mar 11, 2024 •
edited
Loading

@netlify Netlify
Copy link

netlify bot commented Mar 11, 2024 •
edited
Loading

✅ Deploy Preview for scientific-python-hugo-theme ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 7652ac1
🔍 Latest deploy log https://app.netlify.com/sites/scientific-python-hugo-theme/deploys/65ef7006327e9c000897eb7a
😎 Deploy Preview https://deploy-preview-541--scientific-python-hugo-theme.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 82
Accessibility: 100
Best Practices: 100
SEO: 92
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@stefanv
Copy link
Member

stefanv commented Mar 11, 2024

Thank you! I slightly tweaked your proposed PR; let me know if that looks OK to you and we'll merge.

@Schefflera-Arboricola
Copy link
Contributor Author

LGTM!
Thanks @stefanv :)

@jarrodmillman jarrodmillman added the type: Bug fix Something isn't working label Mar 12, 2024
@jarrodmillman jarrodmillman merged commit fded150 into scientific-python:main Mar 12, 2024
6 of 7 checks passed
@jarrodmillman jarrodmillman added this to the 0.14 milestone Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jarrodmillman jarrodmillman jarrodmillman approved these changes

@stefanv stefanv Awaiting requested review from stefanv

Assignees
No one assigned
Labels
type: Bug fix Something isn't working
Projects
None yet
Milestone
0.14
Development

Successfully merging this pull request may close these issues.
3 participants
@Schefflera-Arboricola @stefanv @jarrodmillman