Add comments to SPECs

[stefanv]

No description provided.

[netlify]

✅ Deploy Preview for scientific-python-org ready!

Built without sensitive environment variables

Name	Link
🔨 Latest commit	5345a83
🔍 Latest deploy log	https://app.netlify.com/sites/scientific-python-org/deploys/675095b17b2f9600088e7fec
😎 Deploy Preview	https://deploy-preview-591--scientific-python-org.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 94 Accessibility: 100 Best Practices: 100 SEO: 100 PWA: - View the detailed breakdown and full score reports

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[stefanv]

If this works, I can generalize the comments.html so it can be shared between blog and specs.

[bsipocz]

I don't see any comment fields in the preview. Could you maybe rebase to retrigger for a new build?

[jarrodmillman]

Here is what it looks like on the blog: https://blog.scientific-python.org/scientific-python/dev-summit-2/

[MSanKeys963]

How about we take a look at Giscus?

We use Giscus at https://zarr.dev/blog, and it works fine!
Check here: https://zarr.dev/blog/nasa-power-and-zarr/.

[bsipocz]

Just to record a slight preference, I would very much like not to mix the repo notifications with forum notifications, so if all else equal for the implementation/rendering/etc I would be a 👎 on using github discussions and in favour of going with discourse. We already use the latter for the mailing list and as a forum, and the comments on specs/blog/etc fits nicely into that theme. I think.

[stefanv]

OK, working now. Question: is this the right place for these discussions to show up?

[bsipocz]

I think yes. Can we maybe add a new subtopic though? E.g. there will be specs and then spec discussions? (somehow to distinguish between the initial discussion/pre-pr stuff and once it landed on the website) But this is just an idea and I can see arguments for the opposite, too, to keep all the discussions at the same place.

[stefanv]

I created a new subcategory called "Web comments".

[stefanv]

How about we take a look at Giscus?

I quite like Giscus, and we have a PoC implementation for blog comments.

That said, I feel it's helpful to have all discussions in one place, and since we've been using Discord, since this PR is already done, and since we use Discourse for comments on the blog, we may as well keep going. But, very much not a strong preference.

[MSanKeys963]

I'd like to add to my previous comment that I don't have a strong preference for Giscus. It was something I found useful for our blog and it was easy to implement, so I went ahead with it.

Since we're already using Discourse for SPEC discussions, it makes complete sense to have discussions and comments in the same space. Also, +1 on the idea of creating a subcategory.

Thanks for working on this, @stefanv!

[bsipocz]

Thanks @stefanv!