Dev zelenyy #5
Open
Dev zelenyy #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
March 12, 2022 13:54
Add enum for MODE.
Stop, Move, Reboot, References
Ingvord
commented
Apr 27, 2022
| loop = asyncio.get_event_loop() | ||
| client = MagixHttpClient(kMagixHost) | ||
| observer = AxsisObserver(client, loop) | ||
| observer = AxsisObserver(client, loop, args.host, args.port) | ||
| client.observe(channel=kChannel).pipe( | ||
| ops.filter(lambda event: json.loads(event.data).get('target') == 'axsis'), |
There was a problem hiding this comment.
I believe we will need extra filtering here, namely by IP and port
There was a problem hiding this comment.
By IP and port, these two identify the upstream hardware. Basically we first check that the target, then I would parse the message, because at this point we already know it is addressed to us, and finally filter by IP and port from payload. Otherwise the message may be sent to a wrong hardware... am I right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to merge in dev zelenyy branch