Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix local build (remove git safe.directory) #20

Closed
wants to merge 1 commit into from

Conversation

bkiahstroud
Copy link
Contributor

Story

Allows building docker image locally to succeed by removing the git safe.directory config.

I'm not sure if this change should be committed, but it's what allowed me to spin the project up successfully.

Specs:

  • 2021 MacBook Pro M1
    • MacOS Ventura 13.6
    • Docker Desktop v4.24.0

Expected Behavior Before Changes

Running docker compose build web worker fails

Expected Behavior After Changes

Running docker compose build web worker succeeds

Copy link
Contributor

@orangewolf orangewolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be fixed not just taken out. It got added because builds were failing without it. Why are they passing without it now when they were not before? Something is up.

@bkiahstroud bkiahstroud closed this Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants