Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort jars before searching for mainClass #97

Merged
merged 1 commit into from
Jul 22, 2024
Merged

Conversation

jayvdb
Copy link
Contributor

@jayvdb jayvdb commented Dec 30, 2023

Fixes #90

Copy link

codecov bot commented Dec 30, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.68%. Comparing base (89d20d1) to head (07c9a90).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #97      +/-   ##
==========================================
+ Coverage   94.53%   94.68%   +0.14%     
==========================================
  Files           6        6              
  Lines         879      903      +24     
==========================================
+ Hits          831      855      +24     
  Misses         48       48              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jayvdb
Copy link
Contributor Author

jayvdb commented Jan 10, 2024

ping @ctrueden . I would like to see this merged as py2many currently depends on it for its Kotlin support. c.f. https://github.com/py2many/py2many/blob/main/tox.ini#L31

I would like to do a release soon with a released jgo added as a dependency

@gselzer gselzer requested review from ctrueden and gselzer July 21, 2024 02:36
@ctrueden ctrueden self-assigned this Jul 22, 2024
@ctrueden ctrueden added the bug label Jul 22, 2024
@ctrueden
Copy link
Member

@jayvdb Thanks very much for digging into this and providing a fix. Your solution is succinct and clever. It bothers me that we don't just ask Maven directly for the actual filename of the primary endpoint somehow; but I cannot immediately come up with a concrete example where the sort fails to do the right thing (maybe something with classifiers? but it's a vanishingly small fraction of use cases). So let's just go for it!

@ctrueden ctrueden merged commit 6c92065 into scijava:main Jul 22, 2024
10 checks passed
@jayvdb jayvdb deleted the sort-jars branch July 22, 2024 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ktlint fails only on CI
2 participants