-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Domain-invariant partial least squares regression #286
base: main
Are you sure you want to change the base?
Conversation
Thanks for the PR! It seems your linter changed |
Hi Antoine I have reverted the changes as you suggested but it seems that the tests are still not successful... |
Hello @B-Analytics , You need to merge the README.md file because the current merge conflit prevent te doc and the test from running. |
Got it! |
Hey guys I still face problems with the tests. However, this time the problem is associated with the docs. Following files seem to cause the problem: ../../examples/deep/plot_adversarial.py Can you please give me a hand? |
You can generate and open the doc locally with |
Which version of scikit-learn are you using? |
Yes, I am using scikit-learn v1.5.2 on my local machine. Let me know if I can do something to move this forward. |
Skorch’s new version is coming soon: skorch-dev/skorch#1085. It should fix the CI! |
The scikit-learn team fixed the problem; let's check if the tests pass now! |
Summary
I added the
DIPLS
class along with thedipals
function toskada/_dipls.py
and created an example inexamples/methods/plot_dipls.py
to showcase its usage. In the example, I apply di-PLS to a typical regression task in my domain (analytical chemistry) and tried to highlight the features that make it particularly useful for us (interpretability, flexibility). I also included a comparison with JDOT on the same task. The branch passed all tests (related to the new class and functions) and I updated the documentation accordingly.