-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: add internal with_operation_context
#2525
Conversation
Codecov Report
Additional details and impacted files
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is definitely a maintenance win. I didn't check that the error messages still look okay. If you've checked that, then merge it!
I've changed a couple of the error messages so that the keyword argument names match the signatures (in places where we invoke the context manager manually), and made some of these cases render the |
We want to avoid stateful iterators
This PR refactors our operations to use a decorator for providing an error context. This makes it easier to add new functions, but also improves readability.
Closes #1839