-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: canonicalise union
of indexed
#2527
feat!: canonicalise union
of indexed
#2527
Conversation
union
of indexed
Codecov Report
Additional details and impacted files
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know we had this conversation, but I'll reiterate that I agree that IndexedArray
inside a UnionArray
can get absorbed into the UnionArray
's index
, and therefore should be. Unless it's categorical, which is a user-visible type.
I added the UnionArray.simplified
merge
-argument deprecation to the wiki. (And maybe was too vocal about it being more like a bug-fix than a deprecation, but I don't think it matters what we call it.)
You can merge when ready!
This PR:
merge
argument toUnionArray.simplified
— since the previous introduction of canonicalisation checks, this argument can no longer be meaningfullyFalse
in contexts where layouts are mergeable.IndexedArray
s inside unions.Closes #2192