-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: deprecate string behavior classes #2528
feat!: deprecate string behavior classes #2528
Conversation
Codecov Report
Additional details and impacted files
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is good. It removes all dependence on StringBehavior
and ByteStringBehavior
, making them essentially dead code, apart from the fact that they're a public API. It would be very weird for someone to be using these classes downstream, now that they're not a functional part of Awkward Array anymore, but deprecating, rather than deleting, is the right thing to do.
Let's merge this so that it gets into 2.3.0 on July 1. I've already added it to the list of deprecations.
As discussed in #2432, we don't appear to use these behavior classes anywhere. This PR deprecates them, and removes them from the global behavior dictionary.
This PR doesn't remove the behavior classes for
byte
andchar
, because these are used, including for==
overloads.string
andbytestring
behavior classes