Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add __dask_tokenize__ hook #3017

Merged
merged 4 commits into from
Mar 21, 2024
Merged

feat: add __dask_tokenize__ hook #3017

merged 4 commits into from
Mar 21, 2024

Conversation

lgray
Copy link
Contributor

@lgray lgray commented Feb 11, 2024

This is related to dask/dask#10918

In particular with dask/dask#10883 even those changes don't fix everything.

This at least makes it so that only shape is touched in the present error and with future changes.

This rest is that array.layout.form touches shape.

@codecov-commenter
Copy link

codecov-commenter commented Feb 12, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 81.93%. Comparing base (b749e49) to head (1e7c09b).
Report is 36 commits behind head on main.

Additional details and impacted files
Files Coverage Δ
src/awkward/highlevel.py 76.59% <50.00%> (-0.08%) ⬇️

... and 4 files with indirect coverage changes

src/awkward/highlevel.py Outdated Show resolved Hide resolved
@lgray
Copy link
Contributor Author

lgray commented Feb 12, 2024

Just to link to the wider discussion: dask-contrib/dask-awkward#468

@agoose77
Copy link
Collaborator

@lgray is this still a direction worth pursuing?

@lgray
Copy link
Contributor Author

lgray commented Feb 22, 2024

Yes it is still useful in case people are sticking awkward arrays directly in the graph.

@agoose77
Copy link
Collaborator

Then I think we can merge this. Are there any tests in dask-awkward?

@lgray
Copy link
Contributor Author

lgray commented Feb 22, 2024

Since the operation I mentioned is something you do outside of dask awkward there are no tests in dask awkward for it.

@agoose77
Copy link
Collaborator

@lgray hmm, fair. We can add tests here to check this, then :) Leave it to me ...

@jpivarski
Copy link
Member

This was accepted, but somehow missed getting merged. I'll merge it now.

@jpivarski jpivarski merged commit f2e777f into scikit-hep:main Mar 21, 2024
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants