-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add __dask_tokenize__ hook #3017
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files
|
Just to link to the wider discussion: dask-contrib/dask-awkward#468 |
@lgray is this still a direction worth pursuing? |
Yes it is still useful in case people are sticking awkward arrays directly in the graph. |
Then I think we can merge this. Are there any tests in dask-awkward? |
Since the operation I mentioned is something you do outside of dask awkward there are no tests in dask awkward for it. |
@lgray hmm, fair. We can add tests here to check this, then :) Leave it to me ... |
This was accepted, but somehow missed getting merged. I'll merge it now. |
This is related to dask/dask#10918
In particular with dask/dask#10883 even those changes don't fix everything.
This at least makes it so that only shape is touched in the present error and with future changes.
This rest is that
array.layout.form
touches shape.