Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: to TensorFlow RaggedTensor #3210

Merged
merged 25 commits into from
Aug 27, 2024
Merged

feat: to TensorFlow RaggedTensor #3210

merged 25 commits into from
Aug 27, 2024

Conversation

maxymnaumchyk
Copy link
Collaborator

No description provided.

Copy link

codecov bot commented Aug 12, 2024

Codecov Report

Attention: Patch coverage is 30.50847% with 41 lines in your changes missing coverage. Please review.

Project coverage is 82.24%. Comparing base (b749e49) to head (6e2fd3f).
Report is 144 commits behind head on main.

Files Patch % Lines
src/awkward/operations/ak_to_raggedtensor.py 26.66% 22 Missing ⚠️
src/awkward/operations/ak_from_raggedtensor.py 29.62% 19 Missing ⚠️
Additional details and impacted files
Files Coverage Δ
src/awkward/operations/__init__.py 100.00% <100.00%> (ø)
src/awkward/operations/ak_from_raggedtensor.py 29.62% <29.62%> (ø)
src/awkward/operations/ak_to_raggedtensor.py 26.66% <26.66%> (ø)

... and 102 files with indirect coverage changes

Copy link
Collaborator

@ianna ianna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maxymnaumchyk - good start! Please, run pre-commit run —all locally before pushing.

@maxymnaumchyk maxymnaumchyk marked this pull request as ready for review August 22, 2024 17:39
Copy link
Collaborator

@ianna ianna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maxymnaumchyk - Great job! The implementation is fine. However, the tests do not run in the CI because pytest expects the test names starting with test_. Please, check the suggestions.

tests/test_3210_to_raggedtensor_from_raggedtensor.py Outdated Show resolved Hide resolved
tests/test_3210_to_raggedtensor_from_raggedtensor.py Outdated Show resolved Hide resolved
Co-authored-by: Ianna Osborne <[email protected]>
Copy link
Collaborator

@ianna ianna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maxymnaumchyk - Great, thanks! All tests pass:

tests/test_3210_to_raggedtensor_from_raggedtensor.py::test_convert_to_raggedtensor PASSED [ 99%]
tests/test_3210_to_raggedtensor_from_raggedtensor.py::test_convert_from_raggedtensor PASSED [100%]

@jpivarski - if you don't have any objections I'll merge it. Thanks!

@ianna ianna requested a review from jpivarski August 26, 2024 14:39
Copy link
Member

@jpivarski jpivarski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good! It's well implemented and well tested. I made two suggestions.

src/awkward/operations/ak_to_raggedtensor.py Outdated Show resolved Hide resolved
src/awkward/operations/ak_to_raggedtensor.py Outdated Show resolved Hide resolved
@ianna ianna merged commit 81c48fc into scikit-hep:main Aug 27, 2024
42 checks passed
@jpivarski
Copy link
Member

@all-contributors please add @maxymnaumchyk for code

Copy link
Contributor

@jpivarski

I've put up a pull request to add @maxymnaumchyk! 🎉

@jpivarski
Copy link
Member

Just a note: we'll need to get these new functions into the documentation. It needs to go into https://github.com/scikit-hep/awkward/blob/main/docs/reference/toctree.txt, as a new section

.. toctree::
    :caption: Converting ragged arrays

    generated/ak.from_raggedtensor
    generated/ak.to_raggedtensor

under the "Converting rectangular arrays" section and above the "Reading and writing files" section.

That can be a quick little PR, and when the documentation-generating Action is done, there should be a "View Deployment" button that will let you see what the new documentation looks like. You should find the new documentation on the left side-bar of https://awkward-array.org/doc/main/reference/index.html .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants