Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: cuda max reducer bugfix and more tests #3228

Merged
merged 1 commit into from
Sep 2, 2024
Merged

fix: cuda max reducer bugfix and more tests #3228

merged 1 commit into from
Sep 2, 2024

Conversation

ianna
Copy link
Collaborator

@ianna ianna commented Sep 2, 2024

fixes #3219

@ianna ianna requested a review from jpivarski September 2, 2024 13:49
@codecov Codecov
Copy link

codecov bot commented Sep 2, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.23%. Comparing base (b749e49) to head (429960c).
Report is 147 commits behind head on main.

Additional details and impacted files

see 105 files with indirect coverage changes

ianna
ianna commented Sep 2, 2024
View reviewed changes
Copy link
Collaborator Author

@ianna ianna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jpivarski - please, feel free to merge it if the test pass. This PR only fixes a max reducer bug. The test that fails on the first run issue will be a separate PR. Thanks!

@ianna ianna changed the title fix: cuda reducer bugfix and more tests fix: cuda max reducer bugfix and more tests Sep 2, 2024
@ianna ianna added the gpu Concerns the GPU implementation (backend = "cuda') label Sep 2, 2024
jpivarski
jpivarski approved these changes Sep 2, 2024
View reviewed changes
Copy link
Member

@jpivarski jpivarski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! The tests pass, too. I ought to check it on my GPU, but it will be easier to do that next week. (It can wait that long.)

Meanwhile, I'll merge this now. Thanks!

@jpivarski jpivarski merged commit ebf8bf3 into scikit-hep:main Sep 2, 2024
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpivarski jpivarski jpivarski approved these changes

Assignees
No one assigned
Labels
gpu Concerns the GPU implementation (backend = "cuda')
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CUDA ak.max result on cuda backend doesn't agree with baseline cpu
2 participants
@ianna @jpivarski