Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ListArray slicing on GPU #3248

Merged
merged 20 commits into from
Sep 26, 2024
Merged

fix: ListArray slicing on GPU #3248

merged 20 commits into from
Sep 26, 2024

Commits on Sep 18, 2024

  1. test: add slicing test for CPU and GPU in test_3140_cuda_slicing.py

    @ianna
    ianna authored Sep 18, 2024
    Configuration menu
    Copy the full SHA
    1b826c9 View commit details
    Browse the repository at this point in the history

  2. style: pre-commit fixes

    @pre-commit-ci
    pre-commit-ci[bot] committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    ba9b4d1 View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2024

  1. cast 'at' to int 

    head in this case can be an array and it can be regularized to a proper backend, then the GPU kernel needs to be updated to handle a 'cp.array(0)'
    @ianna
    ianna authored Sep 19, 2024
    Configuration menu
    Copy the full SHA
    ef2609e View commit details
    Browse the repository at this point in the history

  2. style: pre-commit fixes

    @pre-commit-ci
    pre-commit-ci[bot] committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    ed55752 View commit details
    Browse the repository at this point in the history

  3. use ak._slicing.normalize_integer_like(head)

    @ianna
    ianna authored Sep 19, 2024
    Configuration menu
    Copy the full SHA
    bd7b125 View commit details
    Browse the repository at this point in the history

  4. convert head ndarray to scalar

    @ianna
    ianna authored Sep 19, 2024
    Configuration menu
    Copy the full SHA
    298ecf9 View commit details
    Browse the repository at this point in the history

  5. add item attribute to TypeTracerArray

    @ianna
    ianna authored Sep 19, 2024
    Configuration menu
    Copy the full SHA
    2627a51 View commit details
    Browse the repository at this point in the history

  6. cleanup tests

    @ianna
    ianna authored Sep 19, 2024
    Configuration menu
    Copy the full SHA
    6333a6c View commit details
    Browse the repository at this point in the history

  7. Merge branch 'main' into 3213-bad-cuda-kernel-during-slice

    @ianna
    ianna authored Sep 19, 2024
    Configuration menu
    Copy the full SHA
    9bbd8f6 View commit details
    Browse the repository at this point in the history

  8. add more tests

    @ianna
    ianna authored Sep 19, 2024
    Configuration menu
    Copy the full SHA
    da434dc View commit details
    Browse the repository at this point in the history

  9. style: pre-commit fixes

    @pre-commit-ci
    pre-commit-ci[bot] committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    5ed2072 View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2024

  1. use 'ListArray-at' role

    @ianna
    ianna authored Sep 20, 2024
    Configuration menu
    Copy the full SHA
    2fdbb2a View commit details
    Browse the repository at this point in the history

  2. style: pre-commit fixes

    @pre-commit-ci
    pre-commit-ci[bot] committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    095a2ed View commit details
    Browse the repository at this point in the history

  3. use pointer awkward_ListArray_getitem_next_at.cu

    @ianna
    ianna authored Sep 20, 2024
    Configuration menu
    Copy the full SHA
    408a24b View commit details
    Browse the repository at this point in the history

  4. use role listarray.py

    @ianna
    ianna authored Sep 20, 2024
    Configuration menu
    Copy the full SHA
    2a12275 View commit details
    Browse the repository at this point in the history

  5. revert changes

    @ianna
    ianna authored Sep 20, 2024
    Configuration menu
    Copy the full SHA
    13d3a49 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'main' into 3213-bad-cuda-kernel-during-slice

    @ianna
    ianna authored Sep 20, 2024
    Configuration menu
    Copy the full SHA
    84d47a8 View commit details
    Browse the repository at this point in the history

  7. same for awkward_RegularArray_getitem_next_at.cu

    @ianna
    ianna authored Sep 20, 2024
    Configuration menu
    Copy the full SHA
    11f3f4e View commit details
    Browse the repository at this point in the history

  8. remove special case for cuda

    @ianna
    ianna authored Sep 20, 2024
    Configuration menu
    Copy the full SHA
    a7f8f3b View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2024

  1. correct role for jagged size

    @ianna
    ianna authored Sep 23, 2024
    Configuration menu
    Copy the full SHA
    a8845ee View commit details
    Browse the repository at this point in the history