chore: update RapidJSON #3249
Merged
chore: update RapidJSON #3249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
Thanks for catching this! Fortunately, it didn't make its way into any release. #3051 was merged a day after 2.6.8. Aha! I know how you caught this: you have a project in which you're building everything from sources. That's great, and I wonder why our CI didn't catch it—maybe CI is not using this version of gcc? |
jpivarski
approved these changes
Sep 19, 2024
There was a problem hiding this comment.
| Awkward Array's state | RapidJSON version in submodule | relevance of this RapidJSON commit |
|---|---|---|
| Awkward 2.6.7 | rapidjson@3b2441b | one commit after latest release |
| Awkward 2.6.8 | rapidjson@3b2441b | one commit after latest release |
| HEAD, right now | rapidjson@f54b0e4 | latest release |
| this PR | rapidjson@3b2441b | one commit after latest release |
All looks good; I'm going to merge this right away.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
re-applies #3110 which was (I think) accidentally reverted in #3051