build: use cmake build system in fastjet and fastjet-contrib

.github/workflows/ci.yml

@@ -34,35 +34,39 @@ jobs:
       fail-fast: false
       matrix:
         python-version: ["3.9", "3.13"]
-        runs-on: [ubuntu-latest, ubuntu-24.04-arm, macos-latest]
+        runs-on: [ubuntu-latest, ubuntu-24.04-arm, macos-latest, windows-latest]
         arch: [auto64]
     steps:
       - uses: actions/checkout@v4
         with:
           submodules: recursive
+          fetch-depth: 0
 
       - uses: actions/setup-python@v5
         with:
           python-version: ${{ matrix.python-version }}
 
+      - name: Install compiler tools on windows
+        if: runner.os == 'windows'
+        run: |
+          choco install boost-msvc-14.1
+          vcpkg.exe install cgal getopt
+
       - name: Install compiler tools on macOS
         if: runner.os == 'macOS'
         run: |
-          brew install make automake swig gmp mpfr boost libtool
+          brew reinstall gfortran
+          brew install swig boost cgal gmp mpfr
 
       - name: Install extra deps on Linux
         if: runner.os == 'Linux'
-        run: sudo apt-get update && sudo apt-get install -y libboost-dev libmpfr-dev swig autoconf libtool
+        run: sudo apt-get update && sudo apt-get install -y libboost-dev libmpfr-dev swig libcgal-dev
 
-      - name: Install package (MacOS)
+      - name: Install package (macOS)
         if: runner.os == 'macOS'
         run: |
           eval "$(/opt/homebrew/bin/brew shellenv)"
           export PATH="/opt/homebrew/opt/make/libexec/gnubin:/opt/homebrew/opt/libtool/libexec/gnubin:$PATH"
-          export CPPFLAGS+="-I/opt/homebrew/include -L/opt/homebrew/lib"
-          export CXXFLAGS+="-I/opt/homebrew/include -L/opt/homebrew/lib"
-          export CFLAGS+="-I/opt/homebrew/include -L/opt/homebrew/lib"
-          export LDFLAGS+="-L/opt/homebrew/lib"
           python -m pip install '.[test]' -v
 
       - name: Install package (Linux)
@@ -71,6 +75,18 @@ jobs:
           echo $PATH
           python -m pip install '.[test]' -v
 
+      - name: Install package (windows)
+        if: runner.os == 'windows'
+        run: |
+          $Env:Path
+          $Env:CGAL_DIR = 'C:\vcpkg\packages\cgal_x64-windows\share\cgal'
+          $Env:GMP_INC_DIR = 'C:\vcpkg\packages\gmp_x64-windows\include'
+          $Env:GMP_LIB_DIR = 'C:\vcpkg\packages\gmp_x64-windows\lib'
+          $Env:MPFR_INC_DIR = 'C:\vcpkg\packages\mpfr_x64-windows\include'
+          $Env:MPFR_LIB_DIR = 'C:\vcpkg\packages\mpfr_x64-windows\lib'
+          $Env:CMAKE_PREFIX_PATH = "C:\vcpkg\packages\getopt-win32_x64-windows\share\unofficial-getopt-win32;$Env:CMAKE_PREFIX_PATH"
+          python -m pip install '.[test]' -v -C"cmake.define.GMP_DLL_TO_COPY"="C:\\vcpkg\\packages\\gmp_x64-windows\\bin\\gmp-10.dll" -C"cmake.define.FASTJET_ENABLE_DEBUG"="OFF" -C"cmake.define.SISCONE_ENABLE_DEBUG"="OFF"
+
       - name: List installed Python packages
         run: python -m pip list
 
@@ -83,25 +99,33 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        os: [ubuntu-latest, ubuntu-24.04-arm, macos-latest, macos-13]
+        os: [ubuntu-latest, ubuntu-24.04-arm, macos-latest, macos-13, windows-latest]
         python: [313]
         arch: [auto64]
 
     steps:
       - uses: actions/checkout@v4
         with:
           submodules: recursive
+          fetch-depth: 0
 
       - name: Install compiler tools on macOS
         if: runner.os == 'macOS'
         run: |
-          brew install make automake swig mpfr boost libtool
-          echo "PATH=/opt/homebrew/opt/make/libexec/gnubin:/opt/homebrew/opt/libtool/libexec/gnubin:$PATH" >> "$GITHUB_ENV"
-          echo "CPPFLAGS=-I/opt/homebrew/include -L/opt/homebrew/lib $CPPFLAGS" >> "$GITHUB_ENV"
-          echo "CXXFLAGS=-I/opt/homebrew/include -L/opt/homebrew/lib $CXXFLAGS" >> "$GITHUB_ENV"
-          echo "CFLAGS=-I/opt/homebrew/include -L/opt/homebrew/lib $CFLAGS" >> "$GITHUB_ENV"
-          echo "LDFLAGS=-L/opt/homebrew/lib $LDFLAGS" >> "$GITHUB_ENV"
           echo "MACOSX_DEPLOYMENT_TARGET=11.0" >> "$GITHUB_ENV"
+          brew uninstall gcc@12 gcc@13 gnupg gnutls isl libmpc nettle gcc mpfr gmp --ignore-dependencies
+          brew install m4 make automake autoconf libtool swig boost cgal --ignore-dependencies
+          echo "PATH=/opt/homebrew/opt/make/libexec/gnubin:/opt/homebrew/opt/libtool/libexec/gnubin:$PATH" >> "$GITHUB_ENV"
+
+      - name: Install compiler tools on windows
+        if: runner.os == 'windows'
+        run: |
+          choco install boost-msvc-14.1
+          vcpkg.exe install cgal getopt
+
+      - name: Install extra deps on Linux
+        if: runner.os == 'Linux'
+        run: sudo apt-get update && sudo apt-get install -y libboost-dev libmpfr-dev swig libcgal-dev
 
       - name: Clone gmp
         if: runner.os == 'macOS'
@@ -110,7 +134,7 @@ jobs:
           repository: gmp-mirror/gmp-6.3
           path: gmp-6.3
 
-      - name: Build gmp from source for MACOSX_DEPLOYMENT_TARGET
+      - name: Build gmp from source for MACOSX_DEPLOYMENT_TARGET=11.0
         if: runner.os == 'macOS'
         working-directory: gmp-6.3
         run: |
@@ -124,11 +148,40 @@ jobs:
           make --jobs
           make install
 
+      - name: Get mpfr release
+        if: runner.os == 'macOS'
+        run: |
+          curl -Lk https://www.mpfr.org/mpfr-current/mpfr-4.2.2.tar.gz -o mpfr-4.2.2.tar.gz
+          tar -xzf mpfr-4.2.2.tar.gz
+
+      - name: Build mpfr from source for MACOSX_DEPLOYMENT_TARGET=11.0
+        if: runner.os == 'macOS'
+        working-directory: mpfr-4.2.2
+        run: |
+          autoreconf -i -f
+          ./configure --help
+          ./configure \
+            --prefix=$(brew --prefix) \
+            --with-gmp=$(brew --prefix)
+          make --jobs
+          make install
+
       - uses: pypa/[email protected]
         env:
           CIBW_ARCHS: ${{ matrix.arch }}
           CIBW_BUILD: cp${{ matrix.python }}-*
-          CIBW_BUILD_VERBOSITY: 2
+          CIBW_BUILD_VERBOSITY: 1
+          CIBW_CONFIG_SETTINGS_WINDOWS: >
+            "cmake.define.GMP_DLL_TO_COPY"="C:\\\\vcpkg\\\\packages\\\\gmp_x64-windows\\\\bin\\\\gmp-10.dll"
+            "cmake.define.unofficial-getopt-win32_DIR"="C:\\vcpkg\\packages\\getopt-win32_x64-windows\\share\\unofficial-getopt-win32"
+            "cmake.define.FASTJET_ENABLE_DEBUG"="OFF"
+            "cmake.define.SISCONE_ENABLE_DEBUG"="OFF"
+          CIBW_ENVIRONMENT_WINDOWS: >
+            CGAL_DIR='C:\vcpkg\packages\cgal_x64-windows\share\cgal'
+            GMP_INC_DIR='C:\vcpkg\packages\gmp_x64-windows\include'
+            GMP_LIB_DIR='C:\vcpkg\packages\gmp_x64-windows\lib'
+            MPFR_INC_DIR='C:\vcpkg\packages\mpfr_x64-windows\include'
+            MPFR_LIB_DIR='C:\vcpkg\packages\mpfr_x64-windows\lib'
 
       - name: Upload wheels
         uses: actions/upload-artifact@v4

.github/workflows/wheels.yml

@@ -17,6 +17,7 @@ jobs:
       - uses: actions/checkout@v4
         with:
           submodules: recursive
+          fetch-depth: 0
 
       - name: Build SDist
         run: pipx run build --sdist
@@ -33,24 +34,28 @@ jobs:
       fail-fast: false
       matrix:
         python: [39, 310, 311, 312, 313]
-        os: [ubuntu-latest, ubuntu-24.04-arm, macos-latest, macos-13]
+        os: [ubuntu-latest, ubuntu-24.04-arm, macos-latest, macos-13, windows-latest]
         arch: [auto64]
 
     steps:
       - uses: actions/checkout@v4
         with:
           submodules: recursive
+          fetch-depth: 0
 
       - name: Install compiler tools on macOS
         if: runner.os == 'macOS'
         run: |
-          brew install make automake swig mpfr boost libtool
-          echo "PATH=/opt/homebrew/opt/make/libexec/gnubin:/opt/homebrew/opt/libtool/libexec/gnubin:$PATH" >> "$GITHUB_ENV"
-          echo "CPPFLAGS=-I/opt/homebrew/include -L/opt/homebrew/lib $CPPFLAGS" >> "$GITHUB_ENV"
-          echo "CXXFLAGS=-I/opt/homebrew/include -L/opt/homebrew/lib $CXXFLAGS" >> "$GITHUB_ENV"
-          echo "CFLAGS=-I/opt/homebrew/include -L/opt/homebrew/lib $CFLAGS" >> "$GITHUB_ENV"
-          echo "LDFLAGS=-L/opt/homebrew/lib $LDFLAGS" >> "$GITHUB_ENV"
           echo "MACOSX_DEPLOYMENT_TARGET=11.0" >> "$GITHUB_ENV"
+          brew uninstall gcc@12 gcc@13 gnupg gnutls isl libmpc nettle gcc mpfr gmp --ignore-dependencies
+          brew install m4 make automake autoconf libtool swig boost cgal --ignore-dependencies
+          echo "PATH=/opt/homebrew/opt/make/libexec/gnubin:/opt/homebrew/opt/libtool/libexec/gnubin:$PATH" >> "$GITHUB_ENV"
+
+      - name: Install compiler tools on windows
+        if: runner.os == 'windows'
+        run: |
+          choco install boost-msvc-14.1
+          vcpkg.exe install cgal getopt
 
       - name: Clone gmp
         if: runner.os == 'macOS'
@@ -74,11 +79,40 @@ jobs:
           make --jobs
           make install
 
+      - name: Get mpfr release
+        if: runner.os == 'macOS'
+        run: |
+          curl -Lk https://www.mpfr.org/mpfr-current/mpfr-4.2.2.tar.gz -o mpfr-4.2.2.tar.gz
+          tar -xzf mpfr-4.2.2.tar.gz
+
+      - name: Build mpfr from source for MACOSX_DEPLOYMENT_TARGET=11.0
+        if: runner.os == 'macOS'
+        working-directory: mpfr-4.2.2
+        run: |
+          autoreconf -i -f
+          ./configure --help
+          ./configure \
+            --prefix=$(brew --prefix) \
+            --with-gmp=$(brew --prefix)
+          make --jobs
+          make install
+
       - uses: pypa/[email protected]
         env:
           CIBW_ARCHS: ${{ matrix.arch }}
           CIBW_BUILD: cp${{ matrix.python }}-*
-          CIBW_BUILD_VERBOSITY: 2
+          CIBW_BUILD_VERBOSITY: 1
+          CIBW_CONFIG_SETTINGS_WINDOWS: >
+            "cmake.define.GMP_DLL_TO_COPY"="C:\\\\vcpkg\\\\packages\\\\gmp_x64-windows\\\\bin\\\\gmp-10.dll"
+            "cmake.define.unofficial-getopt-win32_DIR"="C:\\vcpkg\\packages\\getopt-win32_x64-windows\\share\\unofficial-getopt-win32"
+            "cmake.define.FASTJET_ENABLE_DEBUG"="OFF"
+            "cmake.define.SISCONE_ENABLE_DEBUG"="OFF"
+          CIBW_ENVIRONMENT_WINDOWS: >
+            CGAL_DIR='C:\vcpkg\packages\cgal_x64-windows\share\cgal'
+            GMP_INC_DIR='C:\vcpkg\packages\gmp_x64-windows\include'
+            GMP_LIB_DIR='C:\vcpkg\packages\gmp_x64-windows\lib'
+            MPFR_INC_DIR='C:\vcpkg\packages\mpfr_x64-windows\include'
+            MPFR_LIB_DIR='C:\vcpkg\packages\mpfr_x64-windows\lib'
 
       - name: Upload wheels
         uses: actions/upload-artifact@v4
@@ -98,7 +132,7 @@ jobs:
 
       - name: Install extra deps on Linux
         if: runner.os == 'Linux'
-        run: sudo apt-get update && sudo apt-get install -y libboost-dev swig autoconf libtool
+        run: sudo apt-get update && sudo apt-get install -y libboost-dev swig autoconf libtool libcgal-dev
 
       - name: test sdist
         run: python -m pip install dist/*.tar.gz

.gitignore

@@ -1,3 +1,4 @@
+src/fastjet/version.py
 _swig.py
 _fastjet_core
 *.so.[0-9]

.gitmodules

@@ -3,4 +3,4 @@
 	url = https://gitlab.com/fastjet/fastjet.git
 [submodule "fastjet-contrib"]
 	path = extern/fastjet-contrib
-	url = https://github.com/cms-externals/fastjet-contrib.git
+	url = https://github.com/lgray/fastjet-contrib.git

.pre-commit-config.yaml

@@ -41,18 +41,11 @@ repos:
   hooks:
   - id: setup-cfg-fmt
 
-- repo: https://github.com/pycqa/flake8
-  rev: 7.2.0
+- repo: https://github.com/astral-sh/ruff-pre-commit
+  rev: v0.11.4
   hooks:
-  - id: flake8
-    exclude: docs/conf.py
-    additional_dependencies: [flake8-bugbear, flake8-print]
-
-- repo: https://github.com/mgedmin/check-manifest
-  rev: "0.50"
-  hooks:
-  - id: check-manifest
-    stages: [manual]
+  - id: ruff
+    args: [--fix, --show-fixes]
 
 - repo: https://github.com/pre-commit/mirrors-clang-format
   rev: "v20.1.0"

CMakeLists.txt

@@ -0,0 +1,52 @@
+cmake_minimum_required(VERSION 3.15...4.0)
+
+if(NOT SKBUILD_PROJECT_VERSION)
+  set(SKBUILD_PROJECT_VERSION "0.0.0")  # provided by scikit-build-core
+endif()
+string(REPLACE "." ";" VERSION_SPLIT ${SKBUILD_PROJECT_VERSION})
+list(GET VERSION_SPLIT 0 SPLIT_VERSION_MAJOR)
+list(GET VERSION_SPLIT 1 SPLIT_VERSION_MINOR)
+
+project(fastjet VERSION ${SPLIT_VERSION_MAJOR}.${SPLIT_VERSION_MINOR} LANGUAGES CXX)
+
+set(PKG_INSTALL "fastjet") ## python package name
+
+include(FetchContent)
+
+find_package(pybind11 REQUIRED)
+
+find_package(CGAL)
+if (NOT CGAL_FOUND)
+  FetchContent_Declare(CGAL
+    GIT_REPOSITORY https://github.com/CGAL/cgal.git
+    GIT_TAG  v6.0.1
+  )
+  FetchContent_MakeAvailable(CGAL)
+endif()
+
+#FetchContent_Declare(fastjet
+#    SOURCE_DIR ${CMAKE_SOURCE_DIR}/extern/fastjet-core
+#    CMAKE_ARGS "-DCMAKE_BUILD_TYPE=\"Release\" -DCMAKE_INSTALL_PREFIX=${CMAKE_INSTALL_PREFIX}/${PKG_INSTALL} -DFASTJET_CUSTOM_PYTHON_INSTALL=lib/${PKG_INSTALL} -DFASTJET_PYTHON_PACKAGE_NAME=_swig -DFASTJET_ENABLE_CGAL=ON"
+#  )
+#FetchContent_MakeAvailable(fastjet)
+
+add_subdirectory(${CMAKE_SOURCE_DIR}/extern/fastjet-core)
+add_subdirectory(${CMAKE_SOURCE_DIR}/extern/fastjet-contrib)
+
+pybind11_add_module(_ext MODULE src/_ext.cpp)
+target_link_libraries(_ext PRIVATE fastjet::fastjet)
+target_link_libraries(_ext PRIVATE EnergyCorrelator LundPlane Nsubjettiness RecursiveTools)
+target_include_directories(_ext PRIVATE ${CMAKE_BINARY_DIR}/include)
+#set_target_properties(_ext PROPERTIES BUILD_WITH_INSTALL_RPATH TRUE)
+#set_target_properties(_ext PROPERTIES INSTALL_RPATH_USE_LINK_PATH TRUE)
+if (${CMAKE_SYSTEM_NAME} MATCHES "Darwin")
+  set_target_properties(_ext PROPERTIES INSTALL_RPATH "@loader_path/lib")
+else()
+  set_target_properties(_ext PROPERTIES INSTALL_RPATH "$ORIGIN/lib")
+endif()
+
+if (MSVC AND FASTJET_ENABLE_CGAL)
+  message("-- Copying ${GMP_DLL_TO_COPY} to project area!")
+  install(FILES ${GMP_DLL_TO_COPY} DESTINATION ${CMAKE_INSTALL_PREFIX})
+endif()
+install(TARGETS _ext LIBRARY DESTINATION ${CMAKE_INSTALL_PREFIX})