Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add powheg-box-v2 lhe testfiles #135

Merged
merged 2 commits into from
Dec 20, 2023
Merged

Conversation

APN-Pucky
Copy link
Member

@APN-Pucky APN-Pucky commented Dec 19, 2023

LHE files for several POWHEG-BOX-V2 processes https://powhegbox.mib.infn.it/ (process details are in the papers for specific process listed on their webpage)

The specific powheg run parameter are included in the beginning comment of the lhe files and correspond to the testrun configurations provided with the powheg box code.

This does not include all processes available, but only a descriptive subset of different setups and processes:

  • pylhe-testfile-powheg-box-v2-W.lhe - W NLO production process
  • pylhe-testfile-powheg-box-v2-Z.lhe - Z NLO production process
  • pylhe-testfile-powheg-box-v2-Zj.lhe - Z+j NLO production process
  • pylhe-testfile-powheg-box-v2-directphoton.lhe - gamma+j NLO production process
  • pylhe-testfile-powheg-box-v2-hvq.lhe - open heavy quark NLO production process
  • pylhe-testfile-powheg-box-v2-trijet.lhe - j+j+j NLO production process

For scikit-hep/pylhe#220

Copy link

codecov bot commented Dec 19, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a3d7245) 69.78% compared to head (129628b) 69.78%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #135   +/-   ##
=======================================
  Coverage   69.78%   69.78%           
=======================================
  Files           3        3           
  Lines         139      139           
=======================================
  Hits           97       97           
  Misses         42       42           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eduardo-rodrigues
Copy link
Member

Hi. For reference can you edit the top-level box to explain what the various files are? This is useful for the future.

This is a very useful addition and we should merge and release. WDYT @jpivarski?

@APN-Pucky
Copy link
Member Author

oh, yes that makes sense. Done.

@eduardo-rodrigues eduardo-rodrigues self-assigned this Dec 20, 2023
@eduardo-rodrigues eduardo-rodrigues merged commit 55fd1e0 into scikit-hep:main Dec 20, 2023
8 checks passed
@eduardo-rodrigues
Copy link
Member

@all-contributors please add @APN-Pucky for data.

Copy link
Contributor

@eduardo-rodrigues

I've put up a pull request to add @APN-Pucky! 🎉

@jpivarski
Copy link
Member

You already merged it, but yes this is good.

@eduardo-rodrigues
Copy link
Member

Thanks and sorry for the rush, Jim. It was a crazy day and I acted where I could when I had a bit of time. Dunno if you have anything else in the pipeline or if you would be happy to make a new release to finalise the enhancement in pylhe? Advance thanks.

@jpivarski
Copy link
Member

I'm glad you went ahead without waiting for me. Adding a few kilobyte-sized files to support pylhe is definitely a good use of this repo.

@eduardo-rodrigues
Copy link
Member

@jpivarski, I'm not sure if you've been doing anything special for the releases but I tagged https://github.com/scikit-hep/scikit-hep-testdata/releases/tag/v0.4.36 and it's not yet on PyPI after 5 minutes or so, which is strange.

@jpivarski
Copy link
Member

You have to make a GitHub release to trigger PyPI deployment, not just a tag. When you make a GitHub release, you can use this existing tag, though.

@eduardo-rodrigues
Copy link
Member

Thanks. But I thought that is what I did at https://github.com/scikit-hep/scikit-hep-testdata/releases? I'm confused as I proceeded as I do for Particle and DecayLanguage. Some setting must be different. If you see the issue, can you fix?

@jpivarski
Copy link
Member

You're right, and I was looking for this thread (on my phone) to follow up, but couldn't find it. I see the release, so it should have triggered. But also, I don't even see the GitHub Action for it in the actions tab or its definition in .github/workflows. I know this has had a GitHub release-triggered deployment, because that's how I've always done it.

@eduardo-rodrigues
Copy link
Member

Thanks for the check. Strange indeed.

In the meantime the conda release got done and merged, see conda-forge/scikit-hep-testdata-feedstock#53.

@eduardo-rodrigues
Copy link
Member

I decided to upload manually to PyPI to get this done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants