Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: RNTuples with custom-length floats and suppressed columns #167

Merged
merged 3 commits into from
Dec 19, 2024

Conversation

ariostas
Copy link
Collaborator

This PR adds root files (and code to generate them) containing RNTuples with custom-length floats and suppressed columns.

Copy link

codecov bot commented Dec 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.38%. Comparing base (ef38efa) to head (21ec32e).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #167   +/-   ##
=======================================
  Coverage   72.38%   72.38%           
=======================================
  Files           3        3           
  Lines         134      134           
=======================================
  Hits           97       97           
  Misses         37       37           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ariostas ariostas requested a review from jpivarski December 19, 2024 14:30
Copy link
Member

@jpivarski jpivarski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I'll merge it and ask at our meeting in 15 minutes whether you're ready for a new release of scikit-hep-testdata.

@jpivarski jpivarski merged commit 797693e into main Dec 19, 2024
7 checks passed
@jpivarski jpivarski deleted the ariostas/more_rntuples branch December 19, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants