fix: show untyped fields and make keys compatible with coffea #1376
Conversation
|
There are further issues. I'll mark it ready for review once the notebook from #1350 works. |
|
@oshadura This is all I can do from the Uproot side. There are more issues because coffea is assuming that it's handling a TTree object, so it's trying to call methods that have no equivalent for RNTuple. I'll try to find some time to look into the coffea side and fix things there. |
There was a problem hiding this comment.
@ariostas - Thanks! Could you, please, have a look at the following test that is failing on ubuntu with Python 3.9:
______________________________ test_support_leafG ______________________________
TypeError: len() of unsized object
The above exception was the direct cause of the following exception:
tmp_path = PosixPath('/tmp/pytest-of-runner/pytest-0/test_support_leafG0')
def test_support_leafG(tmp_path):
filename = os.path.join(tmp_path, "testy.root")
f = ROOT.TFile(filename, "recreate")
t = ROOT.TTree("mytree", "example tree")
n = np.array(2, dtype=np.int32)
> t.Branch("mynum", n, "mynum/I")
f = <cppyy.gbl.TFile object at 0x55f7d34bc640>
filename = '/tmp/pytest-of-runner/pytest-0/test_support_leafG0/testy.root'
n = array(2, dtype=int32)
t = <cppyy.gbl.TTree object at 0x55f7d7f8a980>
tmp_path = PosixPath('/tmp/pytest-of-runner/pytest-0/test_support_leafG0')
tests/test_0840_support_tleafG.py:16:
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
self = <cppyy.gbl.TTree object at 0x55f7d7f8a980>
args = ('mynum', array(2, dtype=int32), 'mynum/I')
def _Branch(self, *args):
# Modify the behaviour if args is one of:
# ( const char*, void*, const char*, Int_t = 32000 )
# ( const char*, const char*, T**, Int_t = 32000, Int_t = 99 )
# ( const char*, T**, Int_t = 32000, Int_t = 99 )
> res = BranchPyz(self, *args)
E SystemError: <built-in function BranchPyz> returned a result with an error set
args = ('mynum', array(2, dtype=int32), 'mynum/I')
self = <cppyy.gbl.TTree object at 0x55f7d7f8a980>
../../../miniconda3/envs/test/lib/python3.9/site-packages/ROOT/_pythonization/_ttree.py:214: SystemError
Re-running the workflow did not help.
Thanks!
|
@ariostas many thanks for quick fix! |
|
@ianna it must have been that some dependency broke something. I ran the workflow on https://github.com/scikit-hep/uproot5/actions/runs/13201682460/job/36854995215 |
|
I was able to reproduce the error. The issue is actually coming from ROOT, which was updated on |
@ariostas - thanks for looking into it! Yes, I think we can skip the test as Python 3.9 is due to reach its scheduled upstream end-of-life in October 2025. |
|
The fix is in #1377. Turns out it wasn't ROOT, but I fixed the test there. |
I changed things so that untyped fields now show up in
keys. Previously, I was ignoring those since I thought they would not be useful, but that's not true. Also, for now I still ignore fields whose name starts with_, but maybe I'll also change this later so that everything appears even though it might come with a lot of garbage.I also changed the
keysfunction so that it takes some arbitrary kwargs and simply ignores them. This fixes #1350, but it is a temporary solution, as coffea needs to switch to using the right kwargs once they fully move to using RNTuples.The keys function is still missing most functionality, but in the interest of having coffea working, I'll leave that for a future PR.