-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: test to check that we can write via xrootd #1380
Conversation
8991136
to
4ca0693
Compare
@ianna the fix was merged in fsspec-xrootd scikit-hep/fsspec-xrootd#76
|
Thanks @maxgalli ! Yes, this is a reasonable suggestion. Let’s wait for the release and then merge it. Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@maxgalli - Thanks! It looks good to me. I wonder if we want to be explicit about the test by adding a skipif
decorator to it.
e7e2d57
to
0e89399
Compare
The tests are passing, but this test, together with all the other ones that use |
This happens for tests running on MacOS and Windows, the Ubuntu case is correctly tested. I opened an issue here #1384 |
This PR introduces a test to check that we can correctly write via XRootD (see #1252).
This test fails with current fsspec-xrootd, but it succeeds when running with the changes introduced in scikit-hep/fsspec-xrootd#76.
We can thus decide to either merge it now but skip the test, or wait until scikit-hep/fsspec-xrootd#76 is merged (and a new version released) and then merge it.