Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: test to check that we can write via xrootd #1380

Merged
merged 5 commits into from
Feb 27, 2025

Conversation

maxgalli
Copy link
Collaborator

This PR introduces a test to check that we can correctly write via XRootD (see #1252).
This test fails with current fsspec-xrootd, but it succeeds when running with the changes introduced in scikit-hep/fsspec-xrootd#76.
We can thus decide to either merge it now but skip the test, or wait until scikit-hep/fsspec-xrootd#76 is merged (and a new version released) and then merge it.

@maxgalli maxgalli changed the title Add test to check that we can write via xrootd fix: test to check that we can write via xrootd Feb 13, 2025
@maxgalli maxgalli force-pushed the 250213_test_uprootwrite branch from 8991136 to 4ca0693 Compare February 17, 2025 09:11
@maxgalli
Copy link
Collaborator Author

@ianna the fix was merged in fsspec-xrootd scikit-hep/fsspec-xrootd#76
what is the ideal procedure now? I guess:

  • release a new version of fsspec-xrootd
  • set a >= like dependency for fsspec-xroot here in uproot (set to the new release containing the bugfix)
  • merge this PR with the new test

@ianna
Copy link
Collaborator

ianna commented Feb 19, 2025

@ianna the fix was merged in fsspec-xrootd scikit-hep/fsspec-xrootd#76 what is the ideal procedure now? I guess:

  • release a new version of fsspec-xrootd
  • set a >= like dependency for fsspec-xroot here in uproot (set to the new release containing the bugfix)
  • merge this PR with the new test

Thanks @maxgalli ! Yes, this is a reasonable suggestion. Let’s wait for the release and then merge it. Thanks.

Copy link
Collaborator

@ianna ianna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maxgalli - Thanks! It looks good to me. I wonder if we want to be explicit about the test by adding a skipif decorator to it.

@maxgalli maxgalli force-pushed the 250213_test_uprootwrite branch 2 times, most recently from e7e2d57 to 0e89399 Compare February 20, 2025 13:33
@maxgalli
Copy link
Collaborator Author

The tests are passing, but this test, together with all the other ones that use xrootd_server https://github.com/scikit-hep/uproot5/blob/main/tests/conftest.py#L83 are being skipped.
This seems to happen in all the tests, and the reason for skipping is that XRootD is not installed. Is there a reason for not having XRootD as a dependency for the tests?

@maxgalli
Copy link
Collaborator Author

The tests are passing, but this test, together with all the other ones that use xrootd_server https://github.com/scikit-hep/uproot5/blob/main/tests/conftest.py#L83 are being skipped. This seems to happen in all the tests, and the reason for skipping is that XRootD is not installed. Is there a reason for not having XRootD as a dependency for the tests?

This happens for tests running on MacOS and Windows, the Ubuntu case is correctly tested. I opened an issue here #1384

@ianna ianna merged commit d08a989 into scikit-hep:main Feb 27, 2025
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants