Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix KeyError by Correcting Key Name in Dataset Loading Process #441

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

mohliyet
Copy link

@mohliyet mohliyet commented May 8, 2024

Description

This pull request addresses issue an issue, where the key name used to access label names in the dataset loading process was incorrect. The key 'lac' has been replaced with the correct key 'label' to ensure proper retrieval of label names.

Motivation and Context:

The motivation behind this change is to rectify the KeyError that occurs during the dataset loading process due to the incorrect key name usage. By replacing the key with the correct one, we ensure that the code functions as intended and retrieves the label names successfully.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Dependencies:

No new dependencies are introduced by this change.

How Has This Been Tested:

  • Ran the updated code with the fix applied.
  • Verified that the KeyError no longer occurs during the dataset loading process.
  • Ensured that label names are retrieved correctly.
  • Ran unit tests to verify the correctness of the fix.

Instructions for Testing:

  1. Pull the latest changes from the repository.
  2. Apply this pull request to your local environment.
  3. Run the dataset loading process.
  4. Verify that the process completes without encountering KeyError.
  5. Check that label names are retrieved correctly.

Checklist

  • I have read the contributing guidelines
  • I have updated the HISTORY.rst and AUTHORS.rst files
  • Linting passes successfully : make lint
  • Typing passes successfully : make type-check
  • Unit tests pass successfully : make tests
  • Coverage is 100% : make coverage
  • Documentation builds successfully : make doc

@mohliyet mohliyet marked this pull request as ready for review May 8, 2024 05:03
@LacombeLouis
Copy link
Collaborator

Hey @mohliyet,
Thank you for this PR! For the moment it doesn't pass some tests, but we have fixed the issue. So you can git merge upstream/main and everything should work!
Thank you!

@Valentin-Laurent
Copy link
Collaborator

Hello @mohliyet, are you still working on that PR?
Happy to help.
Cheers,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants