-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conformal prediction with conditional guarantees #455
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very good first PR, thank you a lot! I give you some suggestions (format, style, code, content ...). To sum up:
- Transform PhiFunction into abstract class.
- Make the comparison with MapieRegressor to foow the same steps (check for instance).
- Remove verbose warning and duplicate checks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Damien-Bouet,
Thank you and well done!
I have made some initial comments in the ccp_regression.py
file. The main thing that I'm noticing is a lot of cast()
and functions that seem exist in other classes. Please note these initial comments, I will have a look further regarding the other files.
…-ccp-classification
…classification Adaptation of Conditional CP method to classification
…inference 506 ccp reoptimize inference
Description
Implementation of new classes
SplitCPRegressor
andCCPCalibrator
(and other subclasses) to implement the method proposed by Gibbs et al. (2023), and described in the issue #449Fixes #449
Type of change
Please remove options that are irrelevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist
make lint
make type-check
make tests
make coverage
make doc