Deprecated argument names in hdbscan_.py #673
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change also increases the minimum required scikit-learn version from 0.2 to 1.6. Maybe it is worth testing which version is available at run-time to keep support for older scikit-learn versions? |
|
If dependencies were declared in pyproject.toml, it would be straightforward to specify scikit-learn version for given python versions. Is there interest in setting that up instead of requirements.txt? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sklearn deprecated
force_all_finiteparam for check_array(). Docs here. There is a deprecation warning when fitting the model. check_array function is used twice in hdbscan_.py. Changed both to new param namingensure_all_finite, functionality is identical.