Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Add required parameters for dti and fODF shells #11

Merged
merged 2 commits into from
Jan 10, 2025

Conversation

gagnonanthony
Copy link
Collaborator

@gagnonanthony gagnonanthony commented Jan 9, 2025

DTI and fODF shells were previously inferred from a threshold that could be specified by --dti_max_shell_value and --fodf_min_fodf_shell_value. However, I find this unstable and not customizable by the user. Therefore, the user will not have to specify which shell to use for both modeling methods using --dti_shells and --fodf_shells.

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • Make sure your code lints (nf-core pipelines lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@gagnonanthony gagnonanthony merged commit d2deb2e into scilus:main Jan 10, 2025
13 checks passed
@gagnonanthony gagnonanthony deleted the fix/dtishells branch January 10, 2025 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant