Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Move freesurfer/fastsurfer output directory alongside output dir for easier reusability #9

Merged
merged 3 commits into from
Jan 8, 2025

Conversation

gagnonanthony
Copy link
Collaborator

@gagnonanthony gagnonanthony commented Jan 8, 2025

Freesurfer outputs are not BIDS-compliant, which breaks the current output file structure. Similar to other pipelines, the output directory for freesurfer/fastsurfer is moved to its dedicated output folder (alongside the nf-pediatric output folder), enhancing reusability in other contexts.

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • Make sure your code lints (nf-core pipelines lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

…pediatric output folder) + fix atlas naming.
@gagnonanthony gagnonanthony added the enhancement New feature or request label Jan 8, 2025
@gagnonanthony gagnonanthony merged commit c4ce1b5 into scilus:main Jan 8, 2025
13 checks passed
@gagnonanthony gagnonanthony deleted the dev branch January 8, 2025 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant