Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement] add easyreg option to subworkflow/registration #215

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

anroy1
Copy link
Contributor

@anroy1 anroy1 commented Sep 12, 2024

Describe your changes

Add the synthbet option to preproc_t1

List test packages used by your module

  • processing.zip

Checklist before requesting a review

  • Create the tool:
    • Edit ./modules/nf-scil/<category>/<tool>/main.nf
    • Edit ./modules/nf-scil/<category>/<tool>/meta.yml
  • Generate the tests:
    • Edit ./tests/modules/nf-scil/<category>/<tool>/main.nf
    • Edit ./tests/modules/nf-scil/<category>/<tool>/nextflow.config
    • Add test data locally for tests with the fork repository
    • Generate the test infrastructure and md5sum for all outputs
  • Ensure the syntax is correct :
    • Check indentation abides with the rest of the library (don't hesitate to correct others !)
    • Lint everything. Ensure your variables have good names.

To Do

niftiMD5SUM
add conditionnal warpconvert

@anroy1 anroy1 changed the title [Improvement] add synthbet option to preproc_t1 [Improvement] add easyreg option to subworkflow/refistration Sep 12, 2024
@AlexVCaron AlexVCaron changed the title [Improvement] add easyreg option to subworkflow/refistration [Improvement] add easyreg option to subworkflow/registration Sep 12, 2024
Copy link
Collaborator

@AlexVCaron AlexVCaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice work ! I think we can merge this fast after another round of review. My comments target syntax mostly. Also, some comments should move you forward to tests working.

subworkflows/nf-scil/registration/main.nf Outdated Show resolved Hide resolved
subworkflows/nf-scil/registration/main.nf Outdated Show resolved Hide resolved
subworkflows/nf-scil/registration/main.nf Outdated Show resolved Hide resolved
subworkflows/nf-scil/registration/main.nf Outdated Show resolved Hide resolved
subworkflows/nf-scil/registration/main.nf Outdated Show resolved Hide resolved
subworkflows/nf-scil/registration/main.nf Outdated Show resolved Hide resolved
subworkflows/nf-scil/registration/main.nf Outdated Show resolved Hide resolved
Copy link

@GuillaumeTh GuillaumeTh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job ! Some small comments from my side.

subworkflows/nf-scil/registration/main.nf Show resolved Hide resolved
subworkflows/nf-scil/registration/meta.yml Outdated Show resolved Hide resolved
subworkflows/nf-scil/registration/meta.yml Outdated Show resolved Hide resolved
subworkflows/nf-scil/registration/meta.yml Outdated Show resolved Hide resolved
.map{ it + [[]] }
transfo_trk = REGISTRATION_EASYREG.out.bak_field
.map{ [[]] + it }
ref_warped - REGISTRATION_EASYREG.out.ref_reg

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what this line is doing.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you referring to ".map{ [[]] + it } or ref_warped output declaration?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In fact it is not a = but a -. So I think you have a bug here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants