Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RF - Input to volume stats scripts #1068

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

gabknight
Copy link
Contributor

@gabknight gabknight commented Dec 3, 2024

Quick description

Add new input features to

  • scil_volume_stats_in_labels.py

    • in_map was replaced by the argument group Metrics input options, allowing for a list of metric filenames or a metric folder;
    • if the scripts as multiple input metrics, the output json file has a new top level dict metric;
    • add add_json_args and corresponding formatting to the output json;
    • this PR changes the interface of the script, i.e. it will break other scripts using it.
  • scil_volume_stats_in_ROI.py

    • change the positional argument in_mask to in_rois, allowing for multiple input mask.
    • if the scripts as multiple input ROIs, the output json file has a new top level dict roi_name;

...

Type of change

Check the relevant options.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Provide data, screenshots, command line to test (if relevant)

...

Checklist

  • My code follows the style guidelines of this project (run autopep8)
  • I added relevant citations to scripts, modules and functions docstrings and descriptions
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I moved all functions from the script file (except the argparser and main) to scilpy modules
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@pep8speaks
Copy link

pep8speaks commented Dec 3, 2024

Hello @gabknight, Thank you for updating !

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2024-12-19 20:50:56 UTC

@gabknight gabknight requested a review from arnaudbore December 3, 2024 21:11
@gabknight gabknight force-pushed the RF_volume_stats branch 2 times, most recently from 56a6bae to 4c185ea Compare December 3, 2024 21:21
Copy link

codecov bot commented Dec 3, 2024

Codecov Report

Attention: Patch coverage is 57.62712% with 25 lines in your changes missing coverage. Please review.

Project coverage is 69.42%. Comparing base (4d2715b) to head (7079040).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1068      +/-   ##
==========================================
+ Coverage   69.41%   69.42%   +0.01%     
==========================================
  Files         447      447              
  Lines       24046    24069      +23     
  Branches     3280     3286       +6     
==========================================
+ Hits        16691    16711      +20     
  Misses       5960     5960              
- Partials     1395     1398       +3     
Components Coverage Δ
Scripts 70.27% <57.62%> (-0.01%) ⬇️
Library 68.30% <ø> (+0.04%) ⬆️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants