-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RF - Input to volume stats scripts #1068
Open
gabknight
wants to merge
8
commits into
scilus:master
Choose a base branch
from
gabknight:RF_volume_stats
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hello @gabknight, Thank you for updating ! There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2024-12-19 20:50:56 UTC |
gabknight
force-pushed
the
RF_volume_stats
branch
2 times, most recently
from
December 3, 2024 21:21
56a6bae
to
4c185ea
Compare
gabknight
force-pushed
the
RF_volume_stats
branch
from
December 3, 2024 21:23
4c185ea
to
7079040
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1068 +/- ##
==========================================
+ Coverage 69.41% 69.42% +0.01%
==========================================
Files 447 447
Lines 24046 24069 +23
Branches 3280 3286 +6
==========================================
+ Hits 16691 16711 +20
Misses 5960 5960
- Partials 1395 1398 +3
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quick description
Add new input features to
scil_volume_stats_in_labels.py
in_map
was replaced by the argument groupMetrics input options
, allowing for a list of metric filenames or a metric folder;metric
;add_json_args
and corresponding formatting to the output json;scil_volume_stats_in_ROI.py
in_mask
toin_rois
, allowing for multiple input mask.roi_name
;...
Type of change
Check the relevant options.
Provide data, screenshots, command line to test (if relevant)
...
Checklist