Feature/visibility #11
Open
+845
−73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 14000611903Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds endpoints for
api/visibility/intervalsandapi/visibility/airmassto get visibility intervals or airmass values for targets at telescopes in a time range. It's using the rise_set library LCO maintains for visibility calculations since its faster and better suited to large queries then the other python options out there.Right now it supports ICRS (ra/dec) targets or non-sidereal orbital elements based minor planets, major planets, or comets targets. It supports the constraints of airmass, lunar phase, and lunar angular separation distance. It can also be filtered by specific telescope. We will need to do more work once we get future planned telescope/instrument states to incorporate those outage times with the intervals returned.