Fix exception handling in PatchOp's replace operation #20
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, PatchOp's internal replace operation handling method would rethrow any exceptions thrown when attempting to remove a value before re-adding it, provided it didn't have a
scimType
ofnoTarget
. This meant that required attribute values could not be replaced, as the call to remove the required attribute's value threw an exception with ascimType
ofinvalidValue
, despite having the value immediately added back.Ultimately, all exceptions thrown in the removal phase of the replace operation can safely be discarded, as the subsequent call to re-add the value will perform its own constraint validation, thereby throwing the same relevant exception thrown in the removal phase (fixes #16).
The test fixtures for the PatchOp message class have also been updated to check that replace operations for required attributes behaves as expected.