Force caseExact and uniqueness config values to be true and none when attribute type is binary
#54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ute as 'caseExact'
…'binary' attributes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, attributes of type
binarycan be defined with acaseExactconfiguration value offalse, and auniquenessconfiguration value of anything other thannone. According to RFC7643§2.3.6, binary attributes are always case-exact and have no uniqueness.This change ensures attributes with type
binarywill, by default, havecaseExactanduniquenessconfiguration values offalseandnonerespectively. It also adds checks to any custom configuration ofbinaryattributes to ensure these values cannot be changed (fixes #44). Test fixtures have also been updated to reflect this change, and to more thoroughly check behaviour when invalid attribute configuration is attempted either at instantiation, or afterward.