Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assign Transformation matrix to odd and even with a binning #280

Open
Vilax opened this issue Nov 24, 2022 · 3 comments
Open

Assign Transformation matrix to odd and even with a binning #280

Vilax opened this issue Nov 24, 2022 · 3 comments
Assignees
Labels
help wanted Extra attention is needed

Comments

@Vilax
Copy link
Contributor

Vilax commented Nov 24, 2022

Consider that we have carried out a odd-even splitting with motioncorr.
MotionCor -> fullTS, oddTS, evenTS

Then a binning to the fullTS is carried out and aligned:

fullTS -> fullTS_binned -> fullTS_binned_aligned

Now we want to applied the alignment of fullTS_binned_aligned to the oddTS. Then the transformation is not well applied, the shifts seems to be properly set. This issue can be related with this one:

scipion-em/scipion-em-imod#155

The solution is to bin oddTS, evenTS and then to assign the transformation matrix to the binned TSodd and even

@pconesa pconesa self-assigned this Nov 24, 2022
@pconesa
Copy link
Contributor

pconesa commented Jun 1, 2023

@Vilax has this been addressed in the last even/ood changes?

@Vilax
Copy link
Contributor Author

Vilax commented Jun 1, 2023

@pconesa this is the old way to deal with odd-even tilt series. the modification that we introduced to deal with odd-even TS is a simpler way. But the old way is still an alternative.

The issue should be still present. It is an old issue, I would check first if it still exists. I can try it, but I am overloaded in the next days. I will let you know

@azazellochg azazellochg self-assigned this Sep 8, 2023
@azazellochg
Copy link
Member

Hi @Vilax
I've run the workflow you suggested and assigned alignment from fullTS_binned_aligned to oddTS from motioncor (bin1). I can see in the output matrix the shifts are scaled properly. Not sure where is the problem..

@azazellochg azazellochg added the help wanted Extra attention is needed label Oct 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants