Support for AND-constraints #980
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
29 tasks
|
Left out are |
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for AND-constraints by introducing new API functions and a test case to validate their behavior.
- Introduces functions to query the number of variables, list the variables, retrieve the resultant variable, check sorting, and perform sorting for AND constraints.
- Updates the changelog to include additional support for AND-constraints.
- Adds a new test case in tests/test_cons.py to verify the behavior of the new functions.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tests/test_cons.py | Added test_cons_and for verifying AND-constraint behavior |
| src/pyscipopt/scip.pxi | New AND-constraint API functions implementation |
| src/pyscipopt/scip.pxd | Extern declarations for new AND-constraint API functions |
| CHANGELOG.md | Updated changelog with support for AND-constraints |
| list of Variable | ||
|
|
||
| """ | ||
| cdef SCIP_VAR** _vars |
There was a problem hiding this comment.
The allocated memory for _vars via malloc is immediately overwritten by the call to SCIPgetVarsAnd, which may lead to a memory leak. Consider removing the malloc call and directly assigning the return value from SCIPgetVarsAnd.
Copilot uses AI. Check for mistakes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's missing:
SCIPchgAndConsCheckFlagWhenUpgr(),SCIPchgAndConsRemovableFlagWhenUpgr(). Not sure if it makes sense to add.As before, I haven't tried to compile, I just copied stuff.
Also moved things around a bit, I think it makes more sense to join methods by constraint handler, like in SCIP's documentation.