Prune workflow in RollingDetectorView #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Working with sciline.Pipeline turns out to be surprisingly slow. Just creating GenericNeXusWorkflow takes close to 200 ms. Pruning the run and monitor types here saves 100 ms in the follow-up code. Since this is called for every detector, it can can add up to about 1 seconds or so in savings. This affects startup time of beamlime services.
jl-wynen
reviewed
Jan 24, 2025
We could, but since it is not a huge problem (done only at startup) I'd rather avoid the complication and instead look into fixing the underlying problem in/via Sciline (see discussion on Slack). |
nvaytet
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working with sciline.Pipeline turns out to be surprisingly slow. Just creating GenericNeXusWorkflow takes close to 200 ms. Pruning the run and monitor types here saves 100 ms in the follow-up code. Since this is called for every detector, it can can add up to about 1 seconds or so in savings for some instruments. This affects startup time of beamlime services.