Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not use exceptions control flow #12

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

HarryR
Copy link

@HarryR HarryR commented Aug 2, 2019

This pull request removes the usage of try ... catch for control flow in the get_evaluation_domain function.

This fixes the problems described by:

When exception control flow is disabled at the compiler-level, either by choice (to generally speed things up) or by requirement (e.g. the Cheerp WASM compiler doesn't support catching exceptions), then the code either abort() or picks the wrong option. This was also triggering misbehaviour with optimised builds on OSX with Clang (where the wrong option is picked, due to buggy catch handling).

This commit also comments-out the comment in the inline-assembly in basic_radix2_domain_aux.tcc, which was breaking Emscripten WASM builds due to it lacking support for inline assembly (of any kind).

There is a different patch in MinaProtocol/mina#1419 but it breaks compatibility with the API, this patch remains API compatibility.

I added the get_root_of_unity_will_throw function, to determine if getting the root of unity will throw, however I need to avoid duplicating the code at:

I will make these changes to be included in the pull request.

@HarryR
Copy link
Author

HarryR commented Aug 2, 2019

I feel there may be a cleaner way of doing this, I am open to suggestions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant