Avoid retrying for 5 minutes after failed key retrieval. #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this, a persistent failure in the key retrieval will not be remembered, meaning rapid-fire retries from the client will result in a similar number of key retrieval attempts. This causes the next_update to be set forward by 5 minutes after each failure.
Test the behavior around an issuer failure -- as long as the cached pubkey isn't expired, we shouldn't try again for 5 minutes.
bbockelm
force-pushed
the
backoff_on_failure
branch
from
6865e3b to
2f14506
Compare
djw8605
reviewed
Nov 1, 2022
| @@ -27,6 +39,216 @@ const char ec_public_2[] = "-----BEGIN PUBLIC KEY-----\n" | |||
| "XWCq4E/g2ME/uBOdP8RE0tqle8fxYcaPikgMcppGq2ycTiLGgEYXgsq2JA==\n" | |||
| "-----END PUBLIC KEY-----\n"; | |||
|
|
|||
| /** | |||
| * Duplicate of get_cache_file from scitokens_cache.cpp; used for direct | |||
| * SQLite manipulation. | |||
There was a problem hiding this comment.
What’s the purpose of these duplicate functions rather than calling the library functions?
There was a problem hiding this comment.
Mainly did this because the underlying functions are internal and not exported by the library as symbols... any ideas on how to get them into the executable instead of duplicating?
|
@djw8605 - did the equivalent of this branch ever make it into the main branch? |
|
@djw8605 ping! ☝️ Did this logic make it into the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.