Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error handling around the sqlite3 library #136

Merged
merged 3 commits into from
Feb 14, 2024

Conversation

bbockelm
Copy link
Contributor

Avoid potentially using the DB object after it has been closed. Noticed this while trying to cleanup valgrind errors in a test host.

Avoid potentially using the DB object after it has been closed.
src/scitokens_cache.cpp Outdated Show resolved Hide resolved
src/scitokens_cache.cpp Outdated Show resolved Hide resolved
bbockelm and others added 2 commits February 11, 2024 20:54
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
bbockelm pushed a commit to opensciencegrid/Software-Redhat that referenced this pull request Feb 12, 2024
@bbockelm
Copy link
Contributor Author

@matyasselmeci has been running this, patched into a production cache, over the course of the day today. The cache was seeing a crash every ~30 minutes before but has been running stably for about 8 hours.

All good signs.

Copy link
Contributor

@djw8605 djw8605 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@djw8605 djw8605 merged commit 0f3d301 into master Feb 14, 2024
7 checks passed
@djw8605 djw8605 deleted the sqlite3_err_handling branch February 14, 2024 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants