Revert "Fix memory leak in rs256_from_coords" #162
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit d0bf032.
DrDaveD
reviewed
Jun 26, 2025
Comment on lines
+535
to
+536
| e_bignum.release(); | ||
| n_bignum.release(); |
There was a problem hiding this comment.
It sure is counter intuitive that adding back releases will fix a free() error, or for that matter deleting them in the original PR fixed a memory leak. One would think the opposite, that calling release() could fix a memory leak and removing it could fix a double-free error.
There was a problem hiding this comment.
Since those variables are unique_ptr, release() in this context actually means for the unique_ptr to stop managing the pointer. So, effectively, it's leaking memory. But really, it must be passing it over to OpenSSL library somewhere.
Sometimes I am envious of memory safe languages like go, or the ownership mechanics of rust.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit d0bf032.
Found with git bisect. Only occurs on el8. Likely an change in OpenSSL behavior?