Openssl 3 0 update #96
Conversation
-Changed internal code to remove use of deprecated functions in openssl 3.0
-Updated to be compatable with JWT-CPP 0.6.0
-Added changes for traits namespace
-Added error_code for sign & verify
-Replaced jwt::token_verification_exception() due
to change from passing string to error_code. I
find the error_code method to be limited and
confusing. So, I replaced with Scitoken local
JWTVerificationException() to use custom error
messages
|
Lots of errors in the build. Could you take a look. |
|
I believe the build failures are due to the code requiring at minimum JWT-CPP v0.5.0 for the json traits change that breaks the api and isn't getting it. In theory you want v0.6.0 for the openssl 3.0 update within JWT-CPP. I am not sure how to change it so the github build uses the correct JWT-CPP version |
|
I have figured out how to make the base requirement of jwt-cpp |
-Updated vendor to include jwt-cpp v0.6.0 not that this is the minmum version to have inorder to have no openssl 3.0 warnings and not break the jwt api
-Fixed JWTVerificationException error throw message to include 'token verification failed:' like it used to have
-PR changes
-Fixed Openssl 3.0 code to store public ec key correctly thus
passing Unit tests
-Set cmake option warnings equal errors to ON thus reverting
to old behavior of failing to compile when a warning occurs
-Implemented JWT-CPP patch into JWT v0.6.0 library included
within vendor to allow for rpm building with older gcc versions
-Reverted attempted fix for rpm building in .spec file due to
compatability update added to JWT-CPP. No longer requires
gcc v5.1 or greater
|
Depending on the rpm building test and your approval I believe all changes are here. I do have a couple of things to note.
Tested in docker Fedora:36 container with Openssl 3. scitoken-verify was successful for both RS256 and ES256 token from demo.scitokens.org, and successfully passed all unit tests. |
|
After a few iterations, I think I'm happy with the pull request. Summary of my changes:
|
-Tested Compilation in Fedora 36 docker container with openssl-devel (3.0.5) and saw no compilation warnings for use of deprecated functions
-Made to be compatible with JWT-CPP 0.6.0 for its openssl 3.0 support
-Minimal testing (Due to lack of know how). scitokens-verify works for both RSA and EC methods.
-Please scrutinize everything. I don't want to break scitokens