update SL keys on both perm and non-perm deletes #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l. Fixes issue where records would be lost on truncated journals where the real records were outside of the 0-max bounds (1000) records.
|
Generating SL keys was only part of the solution. I've also incorporated additional handling that takes these values into account when constructing the BatchGet keys. |
|
Hi @CptnKirk, sorry for the delay: the Akka team is taking over maintainership of this plugin, the new repo is at https://github.com/akka/akka-persistence-dynamodb. We are in the process of updating to Akka 2.4.1, which will change the code around a bit, so I am not yet sure how much this will conflict. My current understanding is that this issue should be solved, so would you mind to submit a PR against the new repo in a few days? Thanks, Roland |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: issue #10