Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix logging reamd #13

Merged
merged 8 commits into from
Jan 21, 2025
Merged

Fix logging reamd #13

merged 8 commits into from
Jan 21, 2025

Conversation

phracek
Copy link
Member

@phracek phracek commented Jan 16, 2025

No description provided.

Signed-off-by: Petr "Stone" Hracek <[email protected]>
Signed-off-by: Petr "Stone" Hracek <[email protected]>
Copy link
Member

@frenzymadness frenzymadness left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did a fast review and found only one real problem and some possible improvements.

README.md Outdated Show resolved Hide resolved
auto_merger/merger.py Outdated Show resolved Hide resolved
auto_merger/pr_checker.py Outdated Show resolved Hide resolved
auto_merger/pr_checker.py Outdated Show resolved Hide resolved
Fix README.md file.

Add more desciption to functions and return boolean
in function that are valid for returning more functions

Signed-off-by: Petr "Stone" Hracek <[email protected]>
Signed-off-by: Petr "Stone" Hracek <[email protected]>
in case it is boolean

Signed-off-by: Petr "Stone" Hracek <[email protected]>
Copy link
Member

@frenzymadness frenzymadness left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've found one typo and some possible improvements in typing.

.github/workflows/python-tests.yml Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
auto_merger/merger.py Outdated Show resolved Hide resolved
auto_merger/merger.py Outdated Show resolved Hide resolved
auto_merger/pr_checker.py Outdated Show resolved Hide resolved
auto_merger/pr_checker.py Outdated Show resolved Hide resolved
auto_merger/pr_checker.py Outdated Show resolved Hide resolved
phracek and others added 3 commits January 21, 2025 10:50
Co-authored-by: Lumír 'Frenzy' Balhar <[email protected]>
Co-authored-by: Lumír 'Frenzy' Balhar <[email protected]>
Signed-off-by: Petr "Stone" Hracek <[email protected]>
@phracek phracek merged commit b913e00 into main Jan 21, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants