Add ct_get_certificate_timestamp and ct_get_certificate_age_s functions #245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[test] |
hhorak
force-pushed
the
certificate_age
branch
2 times, most recently
from
488a037 to
b7734af
Compare
|
[test] |
1 similar comment
|
[test] |
|
[test] |
1 similar comment
|
[test] |
|
[test] |
zmiklank
suggested changes
Aug 9, 2022
|
@hhorak Can you take a look at the comments? |
hhorak
force-pushed
the
certificate_age
branch
from
839540e to
03dff2a
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
This PR is tested in sclorg/httpd-container#140, so not intended to be merged before it's working in CI in that PR. |
…t_image_age_s functions These functions are expected to be used for checking whether a certificate was just generated during the container assembing (e.g age of the certificate is less than a minute). The certificates generation on assembling the container with the application is important for not having the container images with certificates being part of the image.
hhorak
force-pushed
the
certificate_age
branch
from
03dff2a to
13b0f24
Compare
|
[test] |
|
Rebased and sclorg/httpd-container#140 testing it right now, let's see whether tests there are green. |
zmiklank
approved these changes
Jan 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These functions are expected to be used for checking whether a certificate was just
generated during the container assembing (e.g age of the certificate is less than a minute).
The certificates generation on assembling the container with the application is important
for not having the container images with certificates being part of the image.