Add build_args also to ct_s2i_build_as_df function.
#368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have to functions to build image. This one and `ct_test_app_dockerfile` In case of --ulimit is defined in s2i_args variable we will add this parameter to docker/podman command line. Signed-off-by: Petr "Stone" Hracek <[email protected]>
|
[test] |
zmiklank
reviewed
Mar 27, 2024
An example: $ s2i_args="pull-policy=never --incremental -e DEV_MODE=true -v /var/lib/psql --ulimit nofile=4096:4096" $ echo "$s2i_args" | grep -q '\--ulimit' && build_args=$(echo "$s2i_args" | grep -o -e '\--ulimit[[:space:]]\S*\w=*') $ echo $build_args --ulimit nofile=4096:4096 The second example: $ s2i_args="pull-policy=never --incremental -e DEV_MODE=true -v /var/lib/psql --ulimit nofile=4096:4096 -v /etc" $ echo "$s2i_args" | grep -q '\--ulimit' && build_args=$(echo "$s2i_args" | grep -o -e '\--ulimit[[:space:]]\S*\w=*') $ echo $build_args --ulimit nofile=4096:4096 Signed-off-by: Petr "Stone" Hracek <[email protected]>
|
[test] |
Instead of use :centos7 tag Signed-off-by: Petr "Stone" Hracek <[email protected]>
|
[test] |
phracek
force-pushed
the
fix_ulimit_for_building
branch
from
dbc24ff to
47e20af
Compare
Signed-off-by: Petr "Stone" Hracek <[email protected]>
phracek
force-pushed
the
fix_ulimit_for_building
branch
from
47e20af to
3f0dced
Compare
|
I have tested this updated PR with s2i-nodejs-container repo and it works [test] |
zmiklank
reviewed
Apr 2, 2024
Signed-off-by: Petr "Stone" Hracek <[email protected]>
|
[test] |
zmiklank
approved these changes
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add build_args also to
ct_s2i_build_as_dffunction.We have to functions to build image. This one and
ct_test_app_dockerfileIn case of --ulimit is defined in s2i_args variable we will add this parameter to docker/podman command line.
This pull request blocks sclorg/s2i-nodejs-container#425.