-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove set -e and add to the end FAILED message #369
Conversation
in case of test failed. Signed-off-by: Petr "Stone" Hracek <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR, looks good overall, but I've added few comments.
And please, check the shellcheck output. |
Co-authored-by: Zuzana Miklánková <[email protected]>
Signed-off-by: Petr "Stone" Hracek <[email protected]>
[test] |
However, I think this PR does not really solve the problem you want to solve. That would require to remove exit on error from build.sh and tag.sh. However, that is not safe to do, as all of testsuites on our container repos rely on that. |
Currently, in case of |
Signed-off-by: Petr "Stone" Hracek <[email protected]>
Remove set -e and add to the end FAILED message in case test failed.