Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove set -e and add to the end FAILED message #369

Merged
merged 4 commits into from
May 21, 2024
Merged

Conversation

phracek
Copy link
Member

@phracek phracek commented May 20, 2024

Remove set -e and add to the end FAILED message in case test failed.

in case of test failed.

Signed-off-by: Petr "Stone" Hracek <[email protected]>
@phracek phracek requested a review from zmiklank May 20, 2024 11:21
Copy link
Contributor

@zmiklank zmiklank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, looks good overall, but I've added few comments.

test.sh Outdated Show resolved Hide resolved
test.sh Show resolved Hide resolved
test.sh Outdated Show resolved Hide resolved
@zmiklank
Copy link
Contributor

And please, check the shellcheck output.

phracek and others added 2 commits May 20, 2024 14:02
Co-authored-by: Zuzana Miklánková <[email protected]>
@phracek
Copy link
Member Author

phracek commented May 20, 2024

[test]

test.sh Outdated Show resolved Hide resolved
@zmiklank
Copy link
Contributor

However, I think this PR does not really solve the problem you want to solve. That would require to remove exit on error from build.sh and tag.sh. However, that is not safe to do, as all of testsuites on our container repos rely on that.
And if any image is not even buildable - as it the case in this PR - I see no reason to try to run rest of the tests anyway, even for other versions, as unbuildable image is a big problem by itself.

@phracek
Copy link
Member Author

phracek commented May 21, 2024

However, I think this PR does not really solve the problem you want to solve. That would require to remove exit on error from build.sh and tag.sh. However, that is not safe to do, as all of testsuites on our container repos rely on that. And if any image is not even buildable - as it the case in this PR - I see no reason to try to run rest of the tests anyway, even for other versions, as unbuildable image is a big problem by itself.

Currently, in case of build.sh and tag.gs failed then test is not run anymore. Because in both script there is present set -e where it should be.
In case one test has failed, then the next version has to be tested.
This pull request does not belong to building and tagging. Only for tests.

Signed-off-by: Petr "Stone" Hracek <[email protected]>
@phracek phracek merged commit 741a503 into master May 21, 2024
2 checks passed
@phracek phracek deleted the remove_set_e branch May 21, 2024 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants