-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Django to 2.2.12 LTS and related changes #150
Conversation
@frenzymadness It's sad that it won't work on CentOS/RHEL7, however, we want people to switch to 8 anyway. What if we tagged the current version of djangoex (#centos7, #rhel7, #django1), and then from the updated README we can link to one of these tags for people that want to use the old Django version? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The commit Recreated app welcome
added a file welcome/apps.py
but didn't remove any. Is this a new file that's needed, or is it supposed to obsolete some old file(s)?
So that we don't leave useless files lying around confusing users.
Besides this, the PR looks good.
@hhorak Would you be able to recommend someone to help with testing in openshift and updating the openshift documentation links? |
Good idea. I'd need commit rights to do that.
This file is created automatically by Django command
Thanks. |
@pkubatrh Hi, could you please give @frenzymadness commit rights to this repo? |
Ah, perfect. +1 |
@pkubatrh Hi, could you please give @frenzymadness commit rights to this repo? |
I am going to create a new branch |
The new branch for older Django is in: https://github.com/sclorg/django-ex/tree/1.11.x |
@frenzymadness Nice work! |
Basically, this updates this example to Django 2.2.12 (LTS version) and all its dependencies to the latest versions.
There is one big issue: Django >= 2 requires SQLite 3.8.3 but Centos/RHEL 7 contains version 3.7.17 which means that this example will work only of Fedora and Centos/RHEL 8. If we are okay with that, I'll add a note to the readme.
Tested with S2I Python 3 container based on Fedora 31 (Python 3.6):
TODO:
Because I have almost zero knowledge about openshift and no access to that, any help with openshift appreciated.