Image name should be smaller then 64 chars. Minimal has been deleted

Signed-off-by: Petr "Stone" Hracek <[email protected]>
sclorg · Oct 30, 2024 · 1ec8479 · 1ec8479
1 parent f877873
commit 1ec8479
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/charts/redhat/nodejs-application/src/templates/deployment.yaml b/charts/redhat/nodejs-application/src/templates/deployment.yaml
@@ -34,18 +34,18 @@ spec:
       name: {{ .Values.name }}
     spec:
       containers:
+      - name: nodejs-example
         {{ if .Values.registry.enabled }}
-      - image: "{{ .Values.registry.name }}/{{ .Values.registry.namespace }}/{{ .Values.name }}:latest"
+        image: "{{ .Values.registry.name }}/{{ .Values.registry.namespace }}/{{ .Values.name }}:latest"
         {{ else }}
-      - image: " "
+        image: " "
         {{ end }}
         livenessProbe:
           httpGet:
             path: /
             port: 8080
           initialDelaySeconds: 30
           timeoutSeconds: 3
-        name: nodejs-example
         ports:
         - containerPort: 8080
         readinessProbe:

diff --git a/tests/test_nodejs_application.py b/tests/test_nodejs_application.py
@@ -39,7 +39,7 @@ def test_curl_connection(self, version):
         assert self.hc_api.helm_installation()
         self.hc_api.package_name = "nodejs-application"
         assert self.hc_api.helm_package()
-        pod_name = f"nodejs-ex-{version}"
+        pod_name = f"nodejs-ex-{version}".replace("-minimal", "")
         assert self.hc_api.helm_installation(
             values={
                 "nodejs_version": version,
@@ -72,7 +72,7 @@ def test_by_helm_test(self, version):
         assert self.hc_api.helm_installation()
         self.hc_api.package_name = "nodejs-application"
         assert self.hc_api.helm_package()
-        pod_name = f"nodejs-ex-{version}"
+        pod_name = f"nodejs-ex-{version}".replace("-minimal", "")
         assert self.hc_api.helm_installation(
             values={
                 "nodejs": version,